chore: Restore category sort preservation behavior

[gocanto]

Summary

• revert the repository change so category sort values remain unchanged during updates
• update the postgres-backed tests to expect the existing sort to be preserved even when a new value is provided

Testing

• go test ./database/repository -run TestCategoriesExistOrUpdate -count=1 (hangs without required Postgres service; aborted)

---

https://chatgpt.com/codex/tasks/task_e_68f6ffcabac883339e1fc11e591a9a93

Summary by CodeRabbit

• Tests
  • Consolidated category update tests into a single parameterized test covering both zero and non-zero sort values.
  • Verified that category sort order is preserved after updates in all covered scenarios, and that name updates apply as expected.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Replaced two separate tests with a single parameterized test TestCategoriesExistOrUpdatePreservesSort that runs subtests for zero and non-zero Sort values, consolidating setup, update, reload, and assertions to verify Sort is preserved and Name is updated.

Changes

Cohort / File(s)	Summary
Category sort preservation tests database/repository/categories_postgres_test.go	Removed TestCategoriesExistOrUpdatePreservesSortWhenZero and TestCategoriesExistOrUpdateUpdatesSortWhenNonZero; added TestCategoriesExistOrUpdatePreservesSort as a table-driven test using t.Run subtests to cover both zero and non-zero Sort cases and consolidated setup/verification logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• chore: Restore category sort preservation behavior #153: Modifies the same Postgres tests in database/repository/categories_postgres_test.go to assert that category Sort is preserved on update (including non-zero case).
• feat: Add sort order column to categories #151: Introduced the Sort field and earlier tests around its preservation; this change consolidates and replaces specific preservation tests in the same file.

Poem

🐰 I hopped through tests with whiskers bright,
Consolidated cases, both day and night.
Zero or thirty, the sort stays true,
A tidy test garden — neat as dew.
🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "chore: Restore category sort preservation behavior" directly and accurately describes the main change in this pull request. The changeset involves reverting repository logic so that category sort values remain unchanged during updates, and updating the test to verify this preservation behavior. The title clearly communicates this intent using straightforward language ("Restore" and "sort preservation"), is concise at 50 characters, and provides enough specificity that a developer scanning git history would immediately understand the primary purpose of the change without ambiguity.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a57f0c0 and 76be8eb.

📒 Files selected for processing (1)

• database/repository/categories_postgres_test.go (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @gocanto, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on re-establishing the intended behavior for category updates, ensuring that the sort value associated with a category remains constant and is not modified when other category attributes are updated. The changes primarily involve updating the test suite to accurately validate this preservation of the sort order.

Highlights

• Category Sort Preservation: The pull request restores the behavior where category sort values are preserved during update operations, meaning they will not be changed even if a new sort value is provided.
• Test Suite Alignment: The PostgreSQL-backed tests have been updated to reflect this restored behavior, specifically by renaming a test and modifying its assertions to ensure the sort value remains unchanged after an update.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates a test to correctly reflect the intended behavior of preserving the category sort order during an update. The changes are correct and align with the goal of the PR. I've added one suggestion to refactor the tests to improve maintainability by reducing code duplication.