Skip to content

feat: Add bottom back-to-top link to resume page #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

feat: Add bottom back-to-top link to resume page #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/pages/ResumePage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@
<RecommendationPartial v-if="recommendations" :recommendations="recommendations" />
</template>
</div>
<div class="flex justify-end pt-10">
<BackToTopLink />
</div>
Comment on lines +43 to +45
Copy link

@gemini-code-assist gemini-code-assist bot Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The "Back to top" link is currently displayed unconditionally. This can lead to a poor user experience when there is little or no content to scroll through (e.g., if the API returns no entries for education, experience, or recommendations), as the link would be visible even when the page isn't scrollable. It would be better to render this link conditionally, only when there is content displayed on the page.

									<div v-if="(education && education.length) || (experience && experience.length) || (recommendations && recommendations.length)" class="flex justify-end pt-10">
										<BackToTopLink />
									</div>

</section>
</div>
</div>
Expand Down Expand Up @@ -67,6 +70,7 @@ import FooterPartial from '@partials/FooterPartial.vue';
import SideNavPartial from '@partials/SideNavPartial.vue';
import EducationPartial from '@partials/EducationPartial.vue';
import ExperiencePartial from '@partials/ExperiencePartial.vue';
import BackToTopLink from '@partials/BackToTopLink.vue';
import WidgetLangPartial from '@partials/WidgetLangPartial.vue';
import WidgetSkillsPartial from '@partials/WidgetSkillsPartial.vue';
import WidgetSkillsSkeletonPartial from '@partials/WidgetSkillsSkeletonPartial.vue';
Expand Down
Loading