-
Notifications
You must be signed in to change notification settings - Fork 0
chore: Centralise social platform metadata #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gocanto
merged 6 commits into
main
from
gus/use-same-icons-from-widgetsocialpartial-2025-10-16
Oct 16, 2025
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0166f32
Share social platform definitions
gocanto 81f57c4
Add tests for social support module
gocanto 2958674
Align header social icon viewBox
gocanto 10f1f22
Scale header theme toggle icons
gocanto 2040d72
Remove social support tests
gocanto c570146
Add coverage for header social helpers
gocanto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| import { ref } from 'vue'; | ||
| import { describe, it, expect } from 'vitest'; | ||
| import type { SocialResponse } from '@api/response/index.ts'; | ||
| import { socialPlatforms, useHeaderSocialLinks } from '@/support/social.ts'; | ||
|
|
||
| describe('useHeaderSocialLinks', () => { | ||
| it('builds ordered header links with trimmed metadata', () => { | ||
| const social = ref<SocialResponse[]>([ | ||
| { | ||
| uuid: 'github-id', | ||
| name: 'github', | ||
| url: 'https://github.example.com', | ||
| handle: ' ignored ', | ||
| description: ' Showcase ', | ||
| }, | ||
| { | ||
| uuid: 'linkedin-id', | ||
| name: 'linkedin', | ||
| url: 'https://linkedin.example.com', | ||
| handle: ' @example ', | ||
| description: ' ', | ||
| }, | ||
| { | ||
| uuid: 'other-id', | ||
| name: 'mastodon', | ||
| url: 'https://social.example.com', | ||
| handle: '@other', | ||
| description: 'Other network', | ||
| }, | ||
| ]); | ||
|
|
||
| const links = useHeaderSocialLinks(social).value; | ||
|
|
||
| expect(links).toHaveLength(2); | ||
| expect(links[0]).toMatchObject({ | ||
| name: 'github', | ||
| url: 'https://github.example.com', | ||
| label: 'Showcase', | ||
| title: 'Showcase', | ||
| icon: socialPlatforms.github.icon, | ||
| iconClass: expect.stringContaining('text-slate-600'), | ||
| }); | ||
| expect(links[1]).toMatchObject({ | ||
| name: 'linkedin', | ||
| url: 'https://linkedin.example.com', | ||
| label: '@example', | ||
| title: '@example', | ||
| icon: socialPlatforms.linkedin.icon, | ||
| }); | ||
| }); | ||
|
|
||
| it('reacts to social feed updates and falls back to platform name', () => { | ||
| const social = ref<SocialResponse[]>([]); | ||
| const headerLinks = useHeaderSocialLinks(social); | ||
|
|
||
| expect(headerLinks.value).toEqual([]); | ||
|
|
||
| social.value = [ | ||
| { | ||
| uuid: 'linkedin-id', | ||
| name: 'linkedin', | ||
| url: 'https://linkedin.example.com', | ||
| handle: '', | ||
| description: '', | ||
| }, | ||
| ]; | ||
|
|
||
| expect(headerLinks.value).toMatchObject([ | ||
| { | ||
| name: 'linkedin', | ||
| url: 'https://linkedin.example.com', | ||
| label: 'linkedin', | ||
| title: 'linkedin', | ||
| icon: socialPlatforms.linkedin.icon, | ||
| iconClass: expect.stringContaining('text-slate-600'), | ||
| }, | ||
| ]); | ||
|
|
||
| social.value = [ | ||
| { | ||
| uuid: 'github-id', | ||
| name: 'github', | ||
| url: 'https://github.example.com', | ||
| handle: '', | ||
| description: ' ', | ||
| }, | ||
| ]; | ||
|
|
||
| expect(headerLinks.value).toMatchObject([ | ||
| { | ||
| name: 'github', | ||
| url: 'https://github.example.com', | ||
| label: 'github', | ||
| title: 'github', | ||
| icon: socialPlatforms.github.icon, | ||
| iconClass: expect.stringContaining('text-slate-600'), | ||
| }, | ||
| ]); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.