-
Notifications
You must be signed in to change notification settings - Fork 0
Add skeleton loaders for About and Resume pages #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skeleton loaders for About and Resume pages #90
Conversation
WalkthroughAdds skeleton loading UIs to About and Resume pages by introducing two new partial components and integrating them into conditional render flows. Updates tests to cover loading states and clear mocks after each test. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant AboutPage
participant ProfileService as Profile Service
participant AboutConnectSkeletonPartial as About Skeleton
participant EmailLink as Email Link
User->>AboutPage: Navigate
AboutPage->>ProfileService: getProfile()
Note right of AboutPage: While pending
AboutPage-->>About Skeleton: Render v-else (loading)
ProfileService-->>AboutPage: Profile data
AboutPage-->>EmailLink: Render v-if (loaded)
sequenceDiagram
autonumber
actor User
participant ResumePage
participant ProfileService as Profile Service
participant EduService as Education
participant ExpService as Experience
participant RecService as Recommendations
participant ResumePageSkeletonPartial as Resume Skeleton
participant ResumeContent as Resume Sections
User->>ResumePage: Navigate
par Fetch data
ResumePage->>ProfileService: getProfile()
ResumePage->>EduService: getEducation()
ResumePage->>ExpService: getExperience()
ResumePage->>RecService: getRecommendations()
end
Note right of ResumePage: While any pending
ResumePage-->>ResumePageSkeletonPartial: Render v-if (loading)
ProfileService-->>ResumePage: Profile data
EduService-->>ResumePage: Education
ExpService-->>ResumePage: Experience
RecService-->>ResumePage: Recommendations
ResumePage-->>ResumeContent: Render v-else (loaded)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
🧰 Additional context used🧬 Code graph analysis (2)tests/pages/AboutPage.test.ts (1)
tests/pages/ResumePage.test.ts (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @gocanto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience by integrating skeleton loaders into the About and Resume pages. These visual placeholders provide immediate feedback to users that content is being loaded, reducing perceived wait times and improving the overall responsiveness of the application. The changes involve adding new Vue components for the skeletons and updating the respective page components to display them conditionally, along with corresponding unit tests. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68df7dc06b78833399af18871cec0693
Summary by CodeRabbit
New Features
Tests