Skip to content

Conversation

@akomm
Copy link
Contributor

@akomm akomm commented May 4, 2017

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? yes/no
Fixed tickets #131 partially
License MIT

Documentation as proposed in #131.

Copy link
Contributor

@mcg-web mcg-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution. Some minor change then we can merge this...


```yml
# app/config/config_dev.yml
parameters:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be replaced by the bundle configuration:

overblog_graphql:
    templates:
        graphiql: AppBundle:GraphiQL:index.html.twig

Copy link
Contributor

@mcg-web mcg-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot this too. Squash your commits please

{# src/AppBundle/Resources/views/GraphiQL/index.html.twig #}
{% extends 'OverblogGraphQLBundle:GraphiQL:index.html.twig' %}

{% block graphql_fetcher_headers %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing parent call in this example: {{ parent() }}

Copy link
Contributor

@mcg-web mcg-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@mcg-web mcg-web merged commit 4d30217 into overblog:master May 4, 2017
@akomm akomm deleted the docs-graphiql-custom-headers branch August 2, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants