Skip to content

Fix error clientMutationId is removed when equal to 0 and access is used... #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2016
Merged

Fix error clientMutationId is removed when equal to 0 and access is used... #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions Resolver/Config/FieldsConfigSolution.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,14 +195,12 @@ private function filterResultUsingAccess($result, $expression, $values)
$checkAccess = $this->checkAccessCallback($expression, $values);

switch (true) {
case is_array($result) || $result instanceof \ArrayAccess:
$result = array_filter(
array_map(
function ($object) use ($checkAccess) {
return $checkAccess($object) ? $object : null;
},
$result
)
case is_array($result):
$result = array_map(
function ($object) use ($checkAccess) {
return $checkAccess($object) ? $object : null;
},
$result
);
break;

Expand Down
2 changes: 1 addition & 1 deletion Tests/Functional/Security/AccessTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ private function expectedFailedUserRoles()
return [
'data' => [
'user' => [
'roles' => [],
'roles' => [0 => null],
],
],
];
Expand Down
2 changes: 2 additions & 0 deletions Tests/Resolver/Config/FieldsConfigSolutionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ public function testResolveAccessAndWrapResolveCallbackWithArrayAndAccessDeniedT
'tata',
'titi',
'tata',
null,
null,
],
$callback(
[
Expand Down