WIP: Add annotation parser #353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CocoJr
commented
Jul 6, 2018
| /** | ||
| * @\Overblog\GraphQLBundle\Annotation\GraphQLDescription(description="Released in 1977.") | ||
| */ | ||
| const NEWHOPE = 4; |
There was a problem hiding this comment.
Doctrine annotation not work with const
mcg-web
reviewed
Jul 16, 2018
| @@ -0,0 +1,19 @@ | |||
| <?php | |||
There was a problem hiding this comment.
What is the need of this file?
| * @var string | ||
| */ | ||
| public $method; | ||
| } No newline at end of file |
There was a problem hiding this comment.
Can you please give some more ❤️ to PHP CS 😆
There was a problem hiding this comment.
Of course, bad configuration of my new computer :)
| <?php | ||
| /** | ||
| * @author Thibault Colette <thibaultcolette06@hotmail.fr> | ||
| * @copyright 2018 Thibault Colette |
There was a problem hiding this comment.
Can you please remove the copyright statement?
|
@mcg-web Yes it's just a WIP, you can found complete example here: https://github.com/CocoJr/docker-sf4-elasticsearch-graphql-react-express I use a boilerplate project to develop this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use annotation to configure the GraphQL schemas.