fix(sms.sms.compose): display STOP option only when needed (#389)

ref: MBP-52

Author: FredericEspiau

packages/manager/modules/sms/src/sms/compose/index.js

@@ -1,23 +1,25 @@
 import angular from 'angular';
-import controller from './telecom-sms-sms-compose.controller';
-import template from './telecom-sms-sms-compose.html';
+import '@uirouter/angularjs';
+import '@ovh-ux/ng-ovh-telecom-universe-components';
+
+import {
+  component,
+  name as componentName,
+} from './telecom-sms-sms-compose.component';
+
+import routing from './telecom-sms-sms-compose.routing';
 
 import './addPhonebookContact/telecom-sms-sms-compose-addPhonebookContact.less';
 
 const moduleName = 'ovhManagerSmsSmsCompose';
 
-angular.module(moduleName, []).config(($stateProvider) => {
-  $stateProvider.state('sms.service.sms.compose', {
-    url: '/compose',
-    views: {
-      'smsView@sms.service': {
-        template,
-        controller,
-        controllerAs: 'SmsComposeCtrl',
-      },
-    },
-    translations: ['../../../sms/dashboard', '.'],
-  });
-});
+angular
+  .module(moduleName, [
+    'ngOvhTelecomUniverseComponents',
+    'ui.router',
+  ])
+  .component(componentName, component)
+  .config(routing)
+  .run(/* @ngTranslationsInject ./translations */);
 
 export default moduleName;

packages/manager/modules/sms/src/sms/compose/telecom-sms-sms-compose.component.js

@@ -0,0 +1,14 @@
+import controller from './telecom-sms-sms-compose.controller';
+import template from './telecom-sms-sms-compose.html';
+
+export const component = {
+  controller,
+  template,
+};
+
+export const name = 'smsCompose';
+
+export default {
+  component,
+  name,
+};

packages/manager/modules/sms/src/sms/compose/telecom-sms-sms-compose.controller.js

@@ -95,7 +95,6 @@ export default class {
       sender: 'shortNumber',
       senderForResponse: false,
     };
-    this.advice = false;
     this.moreOptions = false;
     this.picker = {
       date: null,
@@ -134,7 +133,7 @@ export default class {
       }
     })).then(() => {
       this.service = this.TucSmsMediator.getCurrentSmsService();
-      this.computeRemainingChar();
+      this.showAdvice();
     })).catch((err) => {
       this.TucToastError(err);
     }).finally(() => {
@@ -236,13 +235,15 @@ export default class {
    * @return {Object}
    */
   showAdvice() {
-    if (this.sms.sender && /[0-9+]/.test(this.sms.sender) && !this.isVirtualNumber()) {
-      this.advice = true;
-      this.sms.noStopClause = true;
-    } else {
-      this.advice = false;
-      this.sms.noStopClause = false;
-    }
+    const isRealNumber = /[0-9+]/.test(this.sms.sender)
+      && !this.isVirtualNumber();
+
+    this.displaySenderCustomizationAdvice = isRealNumber
+      || this.sms.sender === 'shortNumber';
+    this.canHaveSTOPAnswer = !isRealNumber
+      && this.sms.sender !== 'shortNumber';
+    this.sms.noStopClause = isRealNumber;
+
     return this.computeRemainingChar();
   }