fix(telephony.phone): fix order of function keys (#1350)

Author: JeremyDec

packages/manager/apps/telecom/src/app/telecom/telephony/line/phone/programmableKeys/telecom-telephony-line-phone-programmableKeys.constants.js

@@ -0,0 +1,8 @@
+export const ALPHA_NUMERIC_REGEXP = new RegExp(/[a-z]+|[\d.-_]+/ig);
+
+export const COMPLEX_NUMERIC_REGEXP = new RegExp(/\d+/g);
+
+export default {
+  ALPHA_NUMERIC_REGEXP,
+  COMPLEX_NUMERIC_REGEXP,
+};

packages/manager/apps/telecom/src/app/telecom/telephony/line/phone/programmableKeys/telecom-telephony-line-phone-programmableKeys.controller.js

@@ -1,9 +1,15 @@
+import cloneDeep from 'lodash/cloneDeep';
 import filter from 'lodash/filter';
 import find from 'lodash/find';
 import get from 'lodash/get';
 import map from 'lodash/map';
 import set from 'lodash/set';
 
+import {
+  ALPHA_NUMERIC_REGEXP,
+  COMPLEX_NUMERIC_REGEXP,
+} from './telecom-telephony-line-phone-programmableKeys.constants';
+
 export default class TelecomTelephonyLinePhoneProgammableKeysCtrl {
   /* @ngInject */
   constructor($stateParams, $translate, $uibModal, TelephonyMediator, tucTelephonyBulk, TucToast) {
@@ -91,13 +97,31 @@ export default class TelecomTelephonyLinePhoneProgammableKeysCtrl {
     return this.line.getPhone().then(() => {
       if (this.line.hasPhone) {
         return this.line.phone.initDeffered().then(() => {
-          this.functionKeys.raw = angular.copy(this.line.phone.functionKeys);
+          this.functionKeys.raw = cloneDeep(this.line.phone.functionKeys);
+          this.functionKeys.raw.sort(this.constructor.sortFunctionKeys);
         });
       }
       return null;
     });
   }
 
+  static sortFunctionKeys(functionKeyA, functionKeyB) {
+    const [alphaA, numericA] = functionKeyA.label.match(ALPHA_NUMERIC_REGEXP);
+    const [alphaB, numericB] = functionKeyB.label.match(ALPHA_NUMERIC_REGEXP);
+    if (alphaA === alphaB) {
+      const [numericA1, numericA2] = numericA.match(COMPLEX_NUMERIC_REGEXP);
+      const [numericB1, numericB2] = numericB.match(COMPLEX_NUMERIC_REGEXP);
+
+      if (numericA1 === numericB1) {
+        return parseInt(numericA2, 10) > parseInt(numericB2, 10) ? 1 : -1;
+      }
+
+      return parseInt(numericA, 10) > parseInt(numericB, 10) ? 1 : -1;
+    }
+
+    return alphaA > alphaB ? 1 : -1;
+  }
+
   /* ===========================
   =            BULK            =
   ============================ */

packages/manager/apps/telecom/src/app/telecom/telephony/line/phone/programmableKeys/telecom-telephony-line-phone-programmableKeys.html

@@ -36,7 +36,7 @@
             </tuc-telephony-bulk-action>
 
             <oui-datagrid data-rows="ProgrammableKeysCtrl.functionKeys.raw">
-                <oui-column data-title="'telephony_line_phone_programmableKeys_keys_title' | translate" data-property="label" data-sortable="asc">
+                <oui-column data-title="'telephony_line_phone_programmableKeys_keys_title' | translate" data-property="label">
                     <span data-ng-bind="$row.label || '-'"></span>
                 </oui-column>
                 <oui-column data-title="'telephony_line_phone_programmableKeys_function_title' | translate">