feat(oui-slideshow): add new slideshow component #184
Conversation
|
|
||
| | Attribute | Type | Binding | One-time Binding | Values | Default | Description | | ||
| | ---- | ---- | ---- | ---- | ---- | ---- | ---- | | ||
| | `on-dismiss` | function | &? | | | | dismiss callback | |
There was a problem hiding this comment.
(optional) For functions, you could set the binding to & directly.
If undefined, it will call angular.noop() instead.
| this._isTouch = "ontouchstart" in window || navigator.msMaxTouchPoints > 0; | ||
| this._client = { x: 0, y: 0 }; | ||
|
|
||
| this.$document.on("keydown", evt => this._triggerKeyHandler(evt)); |
| } | ||
|
|
||
| $postLink () { | ||
| this.panels = this.$element[0].querySelectorAll("oui-modal-on-boarding-panel"); |
There was a problem hiding this comment.
Since there is DOM manipulations in your $postLink, we should wrap all with
this.$timeout(() => {
[...]
});
| this._isSliding = true; | ||
| const nextIsIllustrated = this._isIllustratedPanel(nextPanelIndex); | ||
|
|
||
| $nextPanel.addClass(direction); |
There was a problem hiding this comment.
Same as $postLink.
This should be in your $timeout below
There was a problem hiding this comment.
DOM is sure all loaded at this time.
I don't think is required to do that !
There was a problem hiding this comment.
👍 I think it's not necessary. $timeout is useful when we make DOM manipulation in $postLink because we're not sure that DOM has been inserted yet. Here, the DOM is clearly ready.
| </div> | ||
| <div class="oui-modal-on-boarding__footer"> | ||
| <div class="oui-modal-on-boarding__indicators" | ||
| data-ng-if="$ctrl.panels.length > 1"> |
There was a problem hiding this comment.
No need of prefixing in our template
|
@rfougier Can you link all your PRs in the description ? Thanks :) |
|
@AxelPeter @rfougier You might consider using a |
rfougier
force-pushed
the
feature/oui-on-boarding
branch
2 times, most recently
from
00ff39b to
8de220a
Compare
| keyCode: 27 | ||
| }); | ||
|
|
||
| // expect(dismissSpy).toHaveBeenCalled(); |
There was a problem hiding this comment.
We don't test anything in this test.
There was a problem hiding this comment.
i forgot to go back on it...
| this._isSliding = true; | ||
| const nextIsIllustrated = this._isIllustratedPanel(nextPanelIndex); | ||
|
|
||
| $nextPanel.addClass(direction); |
There was a problem hiding this comment.
👍 I think it's not necessary. $timeout is useful when we make DOM manipulation in $postLink because we're not sure that DOM has been inserted yet. Here, the DOM is clearly ready.
rfougier
force-pushed
the
feature/oui-on-boarding
branch
from
8de220a to
c2461f5
Compare
rfougier
force-pushed
the
feature/oui-on-boarding
branch
3 times, most recently
from
144046d to
4dbd58b
Compare
AxelPeter
force-pushed
the
feature/oui-on-boarding
branch
from
4dbd58b to
1b38be4
Compare
AxelPeter
force-pushed
the
feature/oui-on-boarding
branch
from
1b38be4 to
a27a89f
Compare
AxelPeter
changed the title
* feat(oui-modal-on-boarding): add oui-modal-on-boarding feature * chore: rename component to oui-slideshow * chore(oui-slideshow): add onboarding theme
5 participants
/#!/oui-angular/modal-on-boarding@ovh_ui_kit_documentation-feature_oui_modal_on_boardingLinked to
ovh/ovh-ui-kit#208
ovh-ux/ovh-ui-kit-documentation#104