This repository was archived by the owner on Aug 7, 2020. It is now read-only.
fix(oui-datagrid): wait row promise before displaying cell template #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenautvh
requested review from
AxelPeter,
Jisay,
antleblanc,
jleveugle and
neolitec
AxelPeter
approved these changes
May 23, 2018
antleblanc
approved these changes
May 23, 2018
FredericEspiau
approved these changes
May 23, 2018
| this.$element.css("display", "block"); | ||
|
|
||
| this._compileCell(); | ||
| if (this.row && this.row.$promise) { |
There was a problem hiding this comment.
Suggestion:
this.$q
.when()
.then(() => _(this.row).get("$promise"))
.finally(() => this._compileCell());There was a problem hiding this comment.
i like your suggestion but i think an "if" is more straightforward and easier to read in that case
whispyy
approved these changes
May 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for row promise to be resolved before displaying row template.
For example :
Will display "Bar" during on the fly row loading which is not intended (we expect cell to be left blank). This fix wait the promise to be resolved and then compile the cell template.