This repository was archived by the owner on Aug 7, 2020. It is now read-only.
feat(oui-switch): add new oui-switch component #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AxelPeter
requested review from
AxelPeter,
JDownloader,
cbourgois,
neolitec,
rfougier and
whispyy
AxelPeter
suggested changes
May 25, 2018
packages/oui-switch/README.md
Outdated
|
|
||
| | Attribute | Type | Binding | One-time Binding | Values | Default | Description | ||
| | ---- | ---- | ---- | ---- | ---- | ---- | ---- | ||
| | label | string | @ | | | | switch label |
There was a problem hiding this comment.
Labels, Help texts should only be managed by the oui-field component.
oui-switch should be a form control, not a form field.
| } | ||
|
|
||
| $postLink () { | ||
| addBooleanParameter(this, "required"); |
There was a problem hiding this comment.
It's already done in the $onInit
packages/oui-switch/src/switch.html
Outdated
| <div class="oui-switch"> | ||
| <label class="oui-switch__label" ng-bind="::$ctrl.label"></label> | ||
| <label class="oui-switch__container"> | ||
| <input type="checkbox" |
There was a problem hiding this comment.
For the form validation, we have to support id and name attributes.
eg. https://github.com/ovh-ux/ovh-ui-angular/blob/master/packages/oui-checkbox/src/checkbox.html#L4
packages/oui-switch/src/switch.html
Outdated
| @@ -0,0 +1,17 @@ | |||
| <div class="oui-switch"> | |||
| <label class="oui-switch__label" ng-bind="::$ctrl.label"></label> | |||
There was a problem hiding this comment.
Duplicate from oui-field
packages/oui-switch/src/switch.html
Outdated
| > | ||
| <div class="oui-switch__slider"></div> | ||
| </label> | ||
| <div class="oui-switch__helper" |
packages/oui-switch/src/switch.html
Outdated
| @@ -0,0 +1,17 @@ | |||
| <div class="oui-switch"> | |||
There was a problem hiding this comment.
If we have only a static class on this DIV, we should add it on the root element oui-switch to remove this one.
|
|
||
| describe("text attribute", () => { | ||
| it("should display a switch label", () => { | ||
| const element = TestUtils.compileTemplate("<oui-switch label=\"test\"></oui-switch>"); |
There was a problem hiding this comment.
The tests should be updated too, if we use oui-field :)
FredericEspiau
approved these changes
May 28, 2018
AxelPeter
approved these changes
May 31, 2018
rfougier
force-pushed
the
feature/oui-switch
branch
2 times, most recently
from
f577953 to
b1b1967
Compare
rfougier
changed the title
rfougier
force-pushed
the
feature/oui-switch
branch
from
b1b1967 to
d8bccf1
Compare
AxelPeter
force-pushed
the
feature/oui-switch
branch
from
9b75473 to
77e0d06
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/#!/ovh-ui-angular/switch @ ovh_ui_kit_documentation-feat_oui_switch_staging
Linked to
ovh/ovh-ui-kit#211
ovh-ux/ovh-ui-kit-documentation#125