This repository was archived by the owner on Aug 7, 2020. It is now read-only.
feat(oui-navbar): add placeholder for notification #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JDownloader
commented
Jun 8, 2018
JDownloader
commented
- show a message when no notification or when something went wong
- add incident level for notifiacation
- show a message when no notification or when something went wong - add incident level for notifiacation
AxelPeter
suggested changes
Jun 11, 2018
packages/oui-navbar/src/navbar.html
Outdated
|
|
||
| </div> | ||
| </li> | ||
| <li class="oui-navbar-menu__item oui-navbar-notification oui-navbar-notification__placeholder" |
There was a problem hiding this comment.
oui-navbar-notification oui-navbar-notification__placeholder
A block and an element at the same level ?
Should be a modifier instead, oui-navbar-notification_placeholder ?
Or maybe a new block:
<li class="oui-navbar-menu__item oui-navbar-notification-placeholder">
packages/oui-navbar/src/navbar.html
Outdated
| aria-hidden="true"> | ||
| </i> | ||
| <div> | ||
| <div class="oui-navbar-notification__placeholder-content-title" |
There was a problem hiding this comment.
...__placeholder-content-title seems to be used as en element of oui-navbar-notification__placeholder-content or oui-navbar-notification__placeholder.
Why not create a new block for that ?
eg. oui-navbar-notification-placeholder, oui-navbar-notification-placeholder__content, oui-navbar-notification-placeholder__title, oui-navbar-notification-placeholder__description
whispyy
approved these changes
Jun 11, 2018
AxelPeter
approved these changes
Jun 12, 2018
neolitec
pushed a commit
that referenced
this pull request
Jun 21, 2018
* feat(oui-navbar): add placeholder for notification - show a message when no notification or when something went wong - add incident level for notifiacation * refactor(oui-navbar): modify class for notification
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.