This repository was archived by the owner on Aug 7, 2020. It is now read-only.
feat(oui-tile): create component #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whispyy
force-pushed
the
feat/tile
branch
3 times, most recently
from
9f9aa22 to
44da7e5
Compare
AxelPeter
suggested changes
Jun 13, 2018
| loadTests(require.context("../../oui-popover/src/", true, /.*((\.spec)|(index))$/)); | ||
| loadTests(require.context("../../oui-stepper/src/", true, /.*((\.spec)|(index))$/)); | ||
| loadTests(require.context("../../oui-skeleton/src/", true, /.*((\.spec)|(index))$/)); | ||
| <<<<<<< HEAD |
packages/oui-tile/README.md
Outdated
| </oui-tile-definition> | ||
| <oui-tile-definition term="Term" term-popover="This is a popover text" description="This is a description"></oui-tile-definition> | ||
| <oui-tile-definition term="Progress"> | ||
| <dd> |
There was a problem hiding this comment.
No need of <dd> if it's already added on your template
| actions: "=?" | ||
| }, | ||
| transclude: { | ||
| descriptionSlot: "?dd", |
There was a problem hiding this comment.
Maybe we should check with something else than <dd>.
What do you think about <oui-tile-description> ?
packages/oui-tile/src/tile.html
Outdated
| @@ -0,0 +1,7 @@ | |||
| <div class="oui-tile"> | |||
| <h4 class="oui-header_4 oui-tile__title" ng-bind="$ctrl.title"></h4> | |||
packages/oui-tile/src/tile.html
Outdated
| @@ -0,0 +1,7 @@ | |||
| <div class="oui-tile"> | |||
| <h4 class="oui-header_4 oui-tile__title" ng-bind="$ctrl.title"></h4> | |||
| <p class="oui-tile__legend" ng-if="!!$ctrl.legend" ng-bind="$ctrl.legend"></p> | |||
|
all corrected |
AxelPeter
approved these changes
Jun 14, 2018
packages/oui-tile/src/tile.html
Outdated
| <h4 class="oui-header_4 oui-tile__title" ng-bind="::$ctrl.heading"></h4> | ||
| <p class="oui-tile__legend" ng-if="!!$ctrl.description" ng-bind="::$ctrl.description"></p> | ||
| <div class="oui-tile__body"> | ||
| <div ng-transclude></div> |
There was a problem hiding this comment.
(optional) Why not setting the transclude directly on oui-tile__body ?
cbourgois
reviewed
Jun 15, 2018
packages/oui-tile/README.md
Outdated
| <oui-tile-definition | ||
| term="Term" | ||
| description="This is a description"> | ||
| <oui-action-menu data-compact> |
There was a problem hiding this comment.
-- data-, we don't do it in our template.
<oui-action-menu align="end" compact>
There was a problem hiding this comment.
Already tried without data for compact attribute but it hasn't worked.
tile tile-button tile-definition test
neolitec
pushed a commit
that referenced
this pull request
Jun 21, 2018
tile tile-button tile-definition test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UK-5
tile
tile-button
tile-definition
test