This repository was archived by the owner on Aug 7, 2020. It is now read-only.
feat(oui-header-tabs): add header-tabs component #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AxelPeter
previously requested changes
Jun 19, 2018
packages/oui-header-tabs/README.md
Outdated
| ### Normal | ||
|
|
||
| ```html:preview | ||
| <div class="oui-doc-preview-only-keep-children"> |
There was a problem hiding this comment.
What's the purpose of this <div> ?
It seems useless, since it has no style or init.
| return { | ||
| restrict: "E", | ||
| template, | ||
| replace: true |
There was a problem hiding this comment.
Sadly, it's deprecated. A previous decision was made to not use it.
We should use another way like .replaceWith() for example: https://docs.angularjs.org/api/ng/function/angular.element
| return { | ||
| restrict: "E", | ||
| template, | ||
| replace: true, |
rfougier
force-pushed
the
feat/oui-header-tabs
branch
2 times, most recently
from
a910022 to
e560b44
Compare
rfougier
force-pushed
the
feat/oui-header-tabs
branch
from
e560b44 to
07857ee
Compare
This was referenced Jun 20, 2018
rfougier
force-pushed
the
feat/oui-header-tabs
branch
from
07857ee to
af9ef46
Compare
whispyy
approved these changes
Jun 21, 2018
rfougier
force-pushed
the
feat/oui-header-tabs
branch
from
af9ef46 to
3cb4181
Compare
neolitec
approved these changes
Jun 21, 2018
rfougier
force-pushed
the
feat/oui-header-tabs
branch
from
3cb4181 to
f803b85
Compare
neolitec
pushed a commit
that referenced
this pull request
Jun 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/#!/ovh-ui-angular/header-tabs@ovh_ui_kit_documentation-feat_oui_header_tabs_stagingLinked to
ovh/ovh-ui-kit#221
ovh-ux/ovh-ui-kit-documentation#121