Skip to content
This repository was archived by the owner on Aug 7, 2020. It is now read-only.

fix(oui-action-menu): allow to disable action menu dynamically #232

Merged
merged 1 commit into from
Jul 17, 2018
Merged

fix(oui-action-menu): allow to disable action menu dynamically #232

merged 1 commit into from
Jul 17, 2018

Conversation

marie-j
Copy link
Contributor

@marie-j marie-j commented Jul 17, 2018

Before : You could only put disabled attribute on oui-action-menu in a static way
Now: disabled attribute accept dynamic values

@marie-j marie-j added the bug label Jul 17, 2018
AxelPeter
AxelPeter approved these changes Jul 17, 2018
View reviewed changes
Copy link
Contributor

@AxelPeter AxelPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find :)

@AxelPeter AxelPeter merged commit cbb7f2a into develop Jul 17, 2018
@AxelPeter AxelPeter deleted the fix/action-menu-disable branch July 17, 2018 14:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@antleblanc antleblanc Awaiting requested review from antleblanc

@Jisay Jisay Awaiting requested review from Jisay

1 more reviewer

@AxelPeter AxelPeter AxelPeter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marie-j @AxelPeter