feat(oui-select): allow items to be disabled #291
Conversation
marie-j
requested review from
AxelPeter,
FredericEspiau,
JeremyDec and
euhmeuh
as code owners
AxelPeter
left a comment
AxelPeter
left a comment
There was a problem hiding this comment.
Nice job :)
Some improvements are needed (documentation and checks). Do you have some unit tests too for this feature ?
| title: "@?", | ||
| placeholder: "@?", | ||
| items: "<", | ||
| disabledItems: "<", |
There was a problem hiding this comment.
This property should be optional: <?
Don't forget to update the API table too :)
packages/oui-select/README.md
Outdated
| data-title="Select a country" | ||
| placeholder="Select a country..." | ||
| items="$ctrl.countries" | ||
| disabled-items="['Algeria', 'Canada', 'France', 'United States']" |
There was a problem hiding this comment.
I think that you should add a note under/above these examples about the fact that disabled-items need an array of values based on the match :)
Since match is optional, how will work this property in the case of the property is not defined ?
This should be documented too.
| } | ||
|
|
||
| if (isArray(this.disabledItems)) { | ||
| this.items = angular.copy(this.items).map(item => |
There was a problem hiding this comment.
We should use another property like this.sortedItems to keep the value of this.item.
What will happened when items or disabled-items is updated after the init ?
| matchElement.html("{{$select.selected}}"); | ||
| } | ||
|
|
||
| if (isArray(this.disabledItems)) { |
There was a problem hiding this comment.
This should be in $onInit instead :)
marie-j
force-pushed
the
feature/oui-select-disabled-options
branch
from
0c951a1 to
4d464fc
Compare
| $onInit () { | ||
| addBooleanParameter(this, "disabled"); | ||
| addBooleanParameter(this, "required"); | ||
|
|
There was a problem hiding this comment.
No need for this blank space :)
marie-j
force-pushed
the
feature/oui-select-disabled-options
branch
from
4d464fc to
0daac4c
Compare
Allow items from oui-select to be disabled