This repository was archived by the owner on Aug 7, 2020. It is now read-only.
feat(oui-datagrid): permit to access row index #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AxelPeter
reviewed
Oct 22, 2018
| .html() | ||
| .trim(); | ||
|
|
||
| expect(actualCellHtml).toBe("test: 0"); |
Contributor
There was a problem hiding this comment.
Maybe we should test another indexes than 0 as a precaution.
Merged
1 task
marie-j
force-pushed
the
feat/oui-datagrid-row-index
branch
from
a6d61c3 to
c39f3a6
Compare
marie-j
requested review from
FredericEspiau,
JeremyDec and
euhmeuh
as code owners
AxelPeter
approved these changes
Oct 23, 2018
FredericEspiau
approved these changes
Oct 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose row index
Description of the Change
Before: it was not possible to use row index value
Now: Row index can be accessed with
$rowIndex