This repository was archived by the owner on Aug 7, 2020. It is now read-only.
fix(oui-select-picker): prevent leaving blank space #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marie-j
requested review from
AxelPeter,
FredericEspiau,
JeremyDec and
euhmeuh
as code owners
AxelPeter
reviewed
Oct 25, 2018
| <oui-select-picker label="Disabled" | ||
| match="name" | ||
| description="Disabled select picker" | ||
| disabled> |
Contributor
There was a problem hiding this comment.
Why removing the disabled example ? If needed, we could add another section of examples.
AxelPeter
reviewed
Oct 25, 2018
Contributor
AxelPeter
left a comment
AxelPeter
left a comment
There was a problem hiding this comment.
The fix seems OK for me, but why updating the existing examples ?
Were they bad or incorrect ?
If no match value is defined an empty section is created
marie-j
force-pushed
the
fix/oui-select-picker-blank-section
branch
from
42ce799 to
1a17df6
Compare
AxelPeter
approved these changes
Oct 29, 2018
JeremyDec
reviewed
Oct 30, 2018
| <span class="oui-select-picker__value" | ||
| ng-bind=":: $ctrl.getFirstValueMatch($ctrl.match)" | ||
| ng-if="$ctrl.values.length === 1"></span> | ||
| ng-bind=":: $ctrl.getFirstValueMatch($ctrl.match)"> |
Contributor
There was a problem hiding this comment.
No alignment ? (For lines 31 & 33)
JeremyDec
approved these changes
Oct 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix/oui select picker blank section
Description of the Change
If there was no
matchattribute set and a section was added, an empty section was createdAlso, if no
matchattribute,selectdisplayed empty values