This repository was archived by the owner on Aug 7, 2020. It is now read-only.
feat(oui-navbar): allow actions on navbar menu links #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marie-j
requested review from
AxelPeter,
FredericEspiau,
JeremyDec and
euhmeuh
as code owners
1 task
JeremyDec
approved these changes
Nov 5, 2018
AxelPeter
suggested changes
Nov 5, 2018
marie-j
force-pushed
the
feat/oui-navbar-links
branch
from
fde5b7d to
0f0c865
Compare
AxelPeter
suggested changes
Nov 5, 2018
marie-j
force-pushed
the
feat/oui-navbar-links
branch
from
0f0c865 to
e5976af
Compare
This was referenced Nov 5, 2018
euhmeuh
approved these changes
Nov 5, 2018
AxelPeter
approved these changes
Nov 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow actions on navbar menu sublinks
Description of the Change
Before: if sublink was a link it was not possible to associate custom action on click
Now: action can be executed on link click