This repository was archived by the owner on Aug 7, 2020. It is now read-only.
feat(oui-dropdown): allow click on link items #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marie-j
requested review from
AxelPeter,
FredericEspiau,
JeremyDec and
euhmeuh
as code owners
AxelPeter
approved these changes
Nov 6, 2018
FredericEspiau
approved these changes
Nov 6, 2018
| expect(link.attr("rel")).toBe("noopener"); | ||
| }); | ||
|
|
||
| it("should call click callback", () => { |
Contributor
There was a problem hiding this comment.
Getter better at this, nice 👍
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow click on all
oui-dropdown-itemDescription of the Change
Before :
on-clickcallback was not available for element withstateorhrefNow:
on-clickcallback is available for alloui-dropdown-item(and thereforeoui-action-menu-item)