This repository was archived by the owner on Aug 7, 2020. It is now read-only.
Feat/dynamic step #313
Merged
Feat/dynamic step #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jisay
requested review from
AxelPeter,
FredericEspiau,
JeremyDec and
euhmeuh
as code owners
AxelPeter
suggested changes
Nov 12, 2018
Contributor
AxelPeter
left a comment
AxelPeter
left a comment
There was a problem hiding this comment.
Need a unit test for your feature and documentation updates.
Otherwise, it's good for me :)
JeremyDec
approved these changes
Nov 12, 2018
AxelPeter
approved these changes
Nov 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some condition steps can be empty. To avoid displaying the empty step, add possibility to display step dynamically with
ngIf.Add a new option:
positionwhich if provided will insert the step to given position inouiStepperCtrl.stepsarray.