This repository was archived by the owner on Aug 7, 2020. It is now read-only.
fix(oui-select-picker): default value #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default value fix when values.length > 1 Close MBP-34
ganeshkumar1989
requested review from
AxelPeter,
FredericEspiau,
JeremyDec and
euhmeuh
as code owners
AxelPeter
approved these changes
Nov 16, 2018
This was referenced Nov 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close MBP-34
Requirements
When there are multiple select-pickers and when more than 1 select picker have multiple 'values' (values.length > 1), then the value attribute of multiple radio buttons created out of the select picker have undefined values i.e. the value attributes are not unique
Default Value Auto Set
Description of the Change
To fix this issue, the first value of the values array is taken as the default value (selectedValue) for a select-picker so that the select pickers have unique values