This repository was archived by the owner on Aug 7, 2020. It is now read-only.
fix(oui-dropdown): fix dropdown menu positioning #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveugle
requested review from
AxelPeter,
FredericEspiau,
JeremyDec and
euhmeuh
as code owners
frenautvh
approved these changes
Jan 21, 2019
cbourgois
approved these changes
Jan 21, 2019
AxelPeter
approved these changes
Jan 21, 2019
FredericEspiau
approved these changes
Jan 21, 2019
Contributor
|
Next time, you can add the explanation to the commit, so we don't lose it ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Description of the Change
Currently, if you have a dropdown inside a DOM element with a
position: absolute, the dropdown will pop at the wrong place.Default parameter of Popper.js fix the issue.
Benefits
Dropdown will now display correctly in that case
Possible Drawbacks
I can't reproduce an issue, which explains why we choose to override some modifiers.
It is possible that in other cases, it is broken. However, we use the default behavior of Popper.js, so the risk is minimal I think.
Applicable Issues
Internal use: OM-266