Skip to content
This repository was archived by the owner on Aug 7, 2020. It is now read-only.

Conversation

@AxelPeter
Copy link
Contributor

Since AngularJS 1.7.6, there is an error when using input[hidden] in oui-file.

To avoid this, the input[hidden] has been changed to input[text], hidden using CSS.

@antleblanc
Copy link
Contributor

antleblanc commented Jan 28, 2019

Shouldn't be handled in the next version?

Both devDependencies and peerDependencies are targeting >=1.6.x.

https://github.com/ovh-ux/ovh-ui-angular/blob/master/package.json#L44
https://github.com/ovh-ux/ovh-ui-angular/blob/master/package.json#L51

@AxelPeter
Copy link
Contributor Author

@antleblanc Yes, and ? It's compatible with 1.6 and 1.7.
I don't see what you mean by your comment.

@antleblanc
Copy link
Contributor

In order to provide support to the v1.7.6 of AngularJS and >=, you may have to reflect these changes on both devDependencies and peerDependencies as well, isn't it?

@AxelPeter AxelPeter merged commit b3763a5 into develop Feb 4, 2019
@AxelPeter AxelPeter deleted the fix/file-input-hidden branch February 4, 2019 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

4 participants