This repository was archived by the owner on Aug 7, 2020. It is now read-only.
Feat/onclick header tab #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add on-click event for header-tabs-item add on-next-slide event oui-slideshow resolves MBE-283, MBE-284
varun257
requested review from
AxelPeter,
FredericEspiau,
JeremyDec and
euhmeuh
as code owners
JeremyDec
suggested changes
Mar 1, 2019
Contributor
|
@varun257 Also, don't hesitate to drop your first commit, in order to have a clean commit history |
AxelPeter
approved these changes
Mar 1, 2019
Contributor
AxelPeter
left a comment
AxelPeter
left a comment
There was a problem hiding this comment.
Except for the comments of @JeremyDec, seems OK for me :)
FredericEspiau
suggested changes
Mar 1, 2019
add on-click event for header-tabs-item add test case and example resolves MBE-283, MBE-284
varun257
force-pushed
the
feat/onclick-header-tab
branch
from
26ffc70 to
19960fa
Compare
JeremyDec
approved these changes
Mar 1, 2019
FredericEspiau
approved these changes
Mar 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add onclick handler for header tab components
Description of the Change
add on-click event for header-tabs-item
add test case and example
Benefits
More options
Possible Drawbacks
None
Applicable Issues
Helps resolve MBE-284