This repository was archived by the owner on Aug 7, 2020. It is now read-only.
feat(oui-collapsible): add handler on toggle open-close event #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svandecappelle
requested review from
AxelPeter,
FredericEspiau,
JeremyDec and
euhmeuh
as code owners
AxelPeter
suggested changes
Mar 19, 2019
svandecappelle
force-pushed
the
feat/add-collapsible-openclose-handler
branch
from
f8f0d94 to
920996f
Compare
Contributor
|
Here's the API table that need to be upated: https://github.com/ovh-ux/ovh-ui-angular/blob/master/packages/oui-collapsible/README.md, and we're good :) |
svandecappelle
force-pushed
the
feat/add-collapsible-openclose-handler
branch
from
920996f to
a845798
Compare
svandecappelle
force-pushed
the
feat/add-collapsible-openclose-handler
branch
from
a845798 to
7b784bc
Compare
AxelPeter
approved these changes
Mar 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add and handler to catch collapsible open-close behaviour
Description of the Change
On header click this now dispatch the toggle event to a function passed in attributes with true/false parameter that defines if the collapsible shows his contents or not.
Benefits
Know the state of the collapsible on change