This repository was archived by the owner on Aug 7, 2020. It is now read-only.
fix(oui-select-picker): update when model changes #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbourgois
requested review from
AxelPeter,
FredericEspiau,
JeremyDec and
euhmeuh
as code owners
JeremyDec
reviewed
Mar 29, 2019
| } | ||
| } | ||
|
|
||
| this.$scope.$watch("$ctrl.model", (newValue) => { |
Contributor
There was a problem hiding this comment.
This cannot be made through $onChanges hook ?
Contributor
Author
There was a problem hiding this comment.
No it doesn't work.
Contributor
There was a problem hiding this comment.
It's because of the binding of the model (=) :)
Could you prefer using a function instead ?
Suggested change
| this.$scope.$watch("$ctrl.model", (newValue) => { | |
| this.$scope.$watch(() => this.model, (newValue) => { |
AxelPeter
approved these changes
Mar 29, 2019
| } | ||
| } | ||
|
|
||
| this.$scope.$watch("$ctrl.model", (newValue) => { |
Contributor
There was a problem hiding this comment.
It's because of the binding of the model (=) :)
Could you prefer using a function instead ?
Suggested change
| this.$scope.$watch("$ctrl.model", (newValue) => { | |
| this.$scope.$watch(() => this.model, (newValue) => { |
cbourgois
force-pushed
the
fix/select-picker-update
branch
from
c1f51a0 to
49f65f7
Compare
AxelPeter
approved these changes
Apr 3, 2019
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(oui-select-picker): update when model changes
Description of the Change
c1f51a0 — fix(oui-select-picker): update when model changes
/cc @jleveugle @frenautvh @antleblanc @marie-j @AxelPeter