This repository was archived by the owner on Aug 7, 2020. It is now read-only.
feat(oui-stepper): add new attribute (editable) #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveugle
requested review from
AxelPeter,
FredericEspiau,
JeremyDec and
euhmeuh
as code owners
cbourgois
approved these changes
Apr 4, 2019
marie-j
approved these changes
Apr 4, 2019
AxelPeter
suggested changes
Apr 4, 2019
Contributor
AxelPeter
left a comment
AxelPeter
left a comment
There was a problem hiding this comment.
Need a unit test, and we're all good :)
5 tasks
By default, after validating a step, user can edit it and update his choice. <oui-step-form header="Simple step" description="This is a description"> we want to let our developpers decide when this update is possible. Today, user can do it as he wishes, this can be problematic in case of loading for example. Example: <oui-step-form header="Simple step" description="This is a description" editable="false"> will result by removing the link: "Modifying this step"
jleveugle
force-pushed
the
feat/oui-stepper-editable
branch
from
8503f8e to
e12bc46
Compare
Contributor
Author
done ;) |
AxelPeter
approved these changes
Apr 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, after validating a step, user can edit it and update his choice.
we want to let our developpers decide when this update is possible. Today, user can do it as he wishes, this can be problematic in case of loading for example.
Example:
will result by removing the link: "Modifying this step"