This repository was archived by the owner on Aug 7, 2020. It is now read-only.
feat(oui-popover): add open, on-open and on-close bindings #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbourgois
requested review from
AxelPeter,
FredericEspiau,
JeremyDec and
euhmeuh
as code owners
cbourgois
force-pushed
the
feat/popover-open
branch
from
15ee0be to
71f7e9a
Compare
cbourgois
force-pushed
the
feat/popover-open
branch
from
71f7e9a to
a4e8613
Compare
cbourgois
requested review from
jleveugle and
marie-j
and removed request for
euhmeuh
marie-j
approved these changes
Apr 9, 2019
4 tasks
AxelPeter
reviewed
Apr 9, 2019
* allow to control popover open state with `open` attribute * add `on-open` and `on-close` triggers
cbourgois
force-pushed
the
feat/popover-open
branch
from
a4e8613 to
ceaa68d
Compare
AxelPeter
approved these changes
Apr 9, 2019
FredericEspiau
approved these changes
Apr 9, 2019
|
|
||
| ```html:preview | ||
| <div class="oui-doc-preview-only"> | ||
| <p><strong>onOpen counter:</strong> {{$ctrl.numOpen }}</p> |
Contributor
There was a problem hiding this comment.
Suggested change
| <p><strong>onOpen counter:</strong> {{$ctrl.numOpen }}</p> | |
| <p><strong>onOpen counter:</strong> {{$ctrl.numOpen}}</p> |
| ```html:preview | ||
| <div class="oui-doc-preview-only"> | ||
| <p><strong>onOpen counter:</strong> {{$ctrl.numOpen }}</p> | ||
| <p><strong>onClose counter:</strong> {{$ctrl.numClose }}</p> |
Contributor
There was a problem hiding this comment.
Suggested change
| <p><strong>onClose counter:</strong> {{$ctrl.numClose }}</p> | |
| <p><strong>onClose counter:</strong> {{$ctrl.numClose}}</p> |
| $postLink () { | ||
| this.setPopover(); | ||
| this.setTrigger(); | ||
| this.setPopover() |
Contributor
There was a problem hiding this comment.
Suggested change
| this.setPopover() | |
| return this.setPopover() |
| } | ||
|
|
||
| $onChanges (changes) { | ||
| if (angular.isDefined(changes.open) && this.triggerElement) { |
Contributor
There was a problem hiding this comment.
Didn't you want to create code as much decoupled from Angular as possible ?
Suggested change
| if (angular.isDefined(changes.open) && this.triggerElement) { | |
| if (changes.open != null && this.triggerElement) { |
or
Suggested change
| if (angular.isDefined(changes.open) && this.triggerElement) { | |
| if (changes.open !== undefined && this.triggerElement) { |
if you are afraid of == :)
| .on("click", () => this.onTriggerClick()); | ||
| }); | ||
|
|
||
| if (angular.isUndefined(this.$attrs.ouiPopoverOpen)) { |
| this.$element.attr("aria-expanded", true); | ||
|
|
||
| // force the digest because the popover is outside the angular digest loop | ||
| this.$timeout(() => this.onOpen(), 0); |
Contributor
There was a problem hiding this comment.
Suggested change
| this.$timeout(() => this.onOpen(), 0); | |
| this.$timeout(() => this.onOpen()); |
is enough, 0 is the default value for the second parameter :)
| this.$element.attr("aria-expanded", false); | ||
|
|
||
| // force the digest because the popover is outside the angular digest loop | ||
| this.$timeout(() => this.onClose(), 0); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(oui-popover): add
open,on-openandon-closebindingsDescription of the Change
openattributeon-openandon-closetriggersceaa68d — feat(oui-popover): add open, on-open and on-close bindings
/cc @jleveugle @marie-j @AxelPeter