This repository was archived by the owner on Aug 7, 2020. It is now read-only.
feat(oui-stepper): add ability to set open step #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marie-j
requested review from
AxelPeter,
FredericEspiau,
JeremyDec and
euhmeuh
as code owners
jleveugle
approved these changes
Apr 18, 2019
AxelPeter
approved these changes
Apr 18, 2019
Jisay
reviewed
Apr 18, 2019
| .addClass("oui-stepper") | ||
| ); | ||
|
|
||
| this.$scope.$watch( |
Contributor
There was a problem hiding this comment.
You can avoid using $scope.$watch by using get/set of es6 :-)
Contributor
Author
There was a problem hiding this comment.
I tried to but I get RangeError: Maximum call stack size exceeded (I suppose due to the fact that currentIndex is needed to be set elsewhere)
AxelPeter
suggested changes
Apr 18, 2019
Contributor
AxelPeter
left a comment
AxelPeter
left a comment
There was a problem hiding this comment.
I've almost missed it. The API table of the documentation is not updated.
No unit test ?
marie-j
force-pushed
the
feat/oui-step-form-opening
branch
from
33e70f3 to
6580a99
Compare
AxelPeter
approved these changes
Apr 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to set open step
Description of the Change
Add
currentIndexas binding to be able to set open stateBenefits
To be able to switch between steps without user action