Skip to content

Commit b96ff13

Browse files
cbourgoisantleblanc
authored andcommitted
fix(sms): add error missing dependencies (#144)
* add angular-messages@^1.7.6 * add angular-ui-validate@^1.2.3 ref: OM-285
1 parent 701fdce commit b96ff13

File tree

7 files changed

+26
-8
lines changed

7 files changed

+26
-8
lines changed

packages/manager/apps/sms/package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
"@ovh-ux/telecom-universe-components": "^1.5.1",
1919
"@uirouter/angularjs": "^1.0.15",
2020
"angular": "1.7.5",
21+
"angular-messages": "^1.7.6",
22+
"angular-ui-validate": "^1.2.3",
2123
"at-internet-ui-router-plugin": "^1.0.0",
2224
"font-awesome": "4.7.0",
2325
"jquery": "^2.1.3",
@@ -36,4 +38,4 @@
3638
"ovh-manager-webfont": "^1.0.2",
3739
"webpack-merge": "^4.1.4"
3840
}
39-
}
41+
}

packages/manager/modules/sms/package.json

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@
1919
"build": "rollup -c --environment BUILD:production",
2020
"dev": "rollup -c --environment BUILD:development",
2121
"dev:watch": "yarn run dev --watch",
22+
"prepare": "yarn run build",
2223
"start": "lerna exec --stream --scope='@ovh-ux/manager-sms' --include-filtered-dependencies -- yarn run build",
2324
"start:dev": "lerna exec --stream --scope='@ovh-ux/manager-sms' --include-filtered-dependencies -- yarn run dev",
24-
"start:watch": "lerna exec --stream --parallel --scope='@ovh-ux/manager-sms' --include-filtered-dependencies -- yarn run dev",
25-
"prepare": "yarn run build"
25+
"start:watch": "lerna exec --stream --parallel --scope='@ovh-ux/manager-sms' --include-filtered-dependencies -- yarn run dev"
2626
},
2727
"dependencies": {
2828
"bootstrap4": "twbs/bootstrap#v4.0.0",
@@ -39,6 +39,8 @@
3939
"@ovh-ux/telecom-universe-components": "^1.5.1",
4040
"@uirouter/angularjs": "^1.0.15",
4141
"angular": "1.7.5",
42+
"angular-messages": "^1.7.6",
43+
"angular-ui-validate": "^1.2.3",
4244
"at-internet-ui-router-plugin": "^1.0.0",
4345
"font-awesome": "4.7.0",
4446
"ng-at-internet": "^3.1.1",
@@ -47,9 +49,9 @@
4749
"ovh-angular-pagination-front": "^6.0.0",
4850
"ovh-angular-responsive-tabs": "^4.0.0",
4951
"ovh-angular-ui-confirm-modal": "^1.0.2",
52+
"ovh-api-services": "^3.31.0",
5053
"ovh-manager-webfont": "^1.0.2",
5154
"ovh-ui-kit": "^2.23.1",
52-
"ovh-ui-kit-bs": "^2.1.1",
53-
"ovh-api-services": "^3.31.0"
55+
"ovh-ui-kit-bs": "^2.1.1"
5456
}
55-
}
57+
}

packages/manager/modules/sms/src/phonebooks/contact-create/telecom-sms-phonebooks-phonebook-contact-create.controller.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export default class {
7676
* @return {Boolean}
7777
*/
7878
isValidNumber(value) {
79-
return !isEmpty(value) ? this.TelecomSmsPhoneBooksNumber.IsValid(value) : true;
79+
return !isEmpty(value) ? this.TelecomSmsPhoneBooksNumber.isValid(value) : true;
8080
}
8181

8282
/**

packages/manager/modules/sms/src/phonebooks/contact-update/telecom-sms-phonebooks-phonebook-contact-update.controller.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ export default class {
8484
* @return {Boolean}
8585
*/
8686
isValidNumber(value) {
87-
return !isEmpty(value) ? this.TelecomSmsPhoneBooksNumber.IsValid(value) : true;
87+
return !isEmpty(value) ? this.TelecomSmsPhoneBooksNumber.isValid(value) : true;
8888
}
8989

9090
/**

packages/manager/modules/sms/src/phonebooks/telecom-sms-phonebooks.component.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import angular from 'angular';
22
import '@uirouter/angularjs';
3+
import 'angular-ui-validate';
34

45
import controller from './telecom-sms-phonebooks.controller';
56
import template from './telecom-sms-phonebooks.html';
@@ -11,6 +12,7 @@ const moduleName = 'ovhManagerSmsPhonebooksComponent';
1112
angular
1213
.module(moduleName, [
1314
'ui.router',
15+
'ui.validate',
1416
create,
1517
])
1618
.config(($stateProvider) => {

packages/manager/modules/sms/src/telecom-sms.component.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import angular from 'angular';
22

33
import '@ovh-ux/telecom-universe-components';
44
import '@ovh-ux/manager-telecom-styles';
5+
import 'angular-messages';
56
import 'ovh-angular-checkbox-table';
67
import 'ovh-angular-responsive-tabs';
78
import 'ovh-angular-pagination-front';
@@ -39,6 +40,7 @@ angular
3940
'ovh-angular-pagination-front',
4041
'ovh-angular-responsive-tabs',
4142
'ovh-api-services',
43+
'ngMessages',
4244
dashboard,
4345
guides,
4446
options,

yarn.lock

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2047,6 +2047,11 @@ angular-messages@^1.7.5:
20472047
resolved "https://registry.yarnpkg.com/angular-messages/-/angular-messages-1.7.5.tgz#7c2fd781315a43a19838b117da0142a988454e14"
20482048
integrity sha512-YDpJpFLyrIgZjE/sIAjgww1y6r3QqXBJbNDI0QjftD37vHXLkwvAOo3A4bxPw8BikyGLcJrFrgf6hRAzntJIWA==
20492049

2050+
angular-messages@^1.7.6:
2051+
version "1.7.6"
2052+
resolved "https://registry.yarnpkg.com/angular-messages/-/angular-messages-1.7.6.tgz#cafddd8d0941b88d58b7eb5094732458840f5533"
2053+
integrity sha512-ch+J1SjK3gbfc7N6epG2+nov59Fdc+8i6Hl+DYxwtlL1X4D3ZhYGymL65gG6fc+yyqBWhZ8athr+lgd5qcu77Q==
2054+
20502055
angular-resource@^1.7.5:
20512056
version "1.7.5"
20522057
resolved "https://registry.yarnpkg.com/angular-resource/-/angular-resource-1.7.5.tgz#80007af3aed8b6278bf2344e8e5257ea7bca333e"
@@ -2079,6 +2084,11 @@ angular-ui-bootstrap@~1.3.3:
20792084
resolved "https://registry.yarnpkg.com/angular-ui-bootstrap/-/angular-ui-bootstrap-1.3.3.tgz#4820f895d433c17abeb4ac7387f2f122cbf8c11c"
20802085
integrity sha1-SCD4ldQzwXq+tKxzh/LxIsv4wRw=
20812086

2087+
angular-ui-validate@^1.2.3:
2088+
version "1.2.3"
2089+
resolved "https://registry.yarnpkg.com/angular-ui-validate/-/angular-ui-validate-1.2.3.tgz#beb141f64409bfddba65c12f7581b893ddf59321"
2090+
integrity sha1-vrFB9kQJv926ZcEvdYG4k931kyE=
2091+
20822092
angular-validation-match@^1.4.0:
20832093
version "1.9.0"
20842094
resolved "https://registry.yarnpkg.com/angular-validation-match/-/angular-validation-match-1.9.0.tgz#03d82d0b983bf22366c5d22a0c291731625dcf80"

0 commit comments

Comments
 (0)