Skip to content

fix(ldp): handle resource name #10197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qpavy merged 2 commits into from
Oct 27, 2023
Merged

fix(ldp): handle resource name #10197

qpavy merged 2 commits into from
Oct 27, 2023

Conversation

@pdepaepe
Copy link
Member

@pdepaepe pdepaepe commented Oct 27, 2023

ref: OB-5258

Question Answer
Branch? master
Bug fix? no
New feature? no
Breaking change? no
Tickets Fix #OB-5258
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated, because already made here: fix(ldp): handle resource name #10111
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

We expect to have new units to forward their logs anytime. Actually, the way that the related resource is translated on subscription page display a raw key not user friendly.

translation :

  • CMT-4796

fork of: #10111

@pdepaepe
fix(ldp): handle resource name
163b55d 
ref: OB-5258

Signed-off-by: Pierre De Paepe <pierre.de-paepe@ovhcloud.com>
@pdepaepe
fix(i18n): add missing translations [CDS 2583]
203952f 
Signed-off-by: CDS Translator Agent <opensource@ovh.net>
@pdepaepe pdepaepe requested review from a team, benjaminlepine, darsene and karim-ovh October 27, 2023 11:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@qpavy qpavy changed the base branch from master to release/components-w44 October 27, 2023 11:59
@qpavy qpavy merged commit 2480cb0 into release/components-w44 Oct 27, 2023
@qpavy qpavy deleted the ldp_improvements_231027 branch October 27, 2023 12:01
@qpavy qpavy mentioned this pull request Oct 27, 2023
Merged
13 tasks
qpavy pushed a commit that referenced this pull request Oct 30, 2023
@pdepaepe @qpavy
fix(dedicated): ldp handle resource name (#10197)
cf3355a 
ref: OB-5258

Signed-off-by: Pierre De Paepe <pierre.de-paepe@ovhcloud.com>
Co-authored-by CDS Translator Agent <opensource@ovh.net>
blemoineovh pushed a commit that referenced this pull request Dec 10, 2023
@pdepaepe @blemoineovh
fix(dedicated): ldp handle resource name (#10197)
a4e1102 
ref: OB-5258

Signed-off-by: Pierre De Paepe <pierre.de-paepe@ovhcloud.com>
Co-authored-by CDS Translator Agent <opensource@ovh.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ghyenne ghyenne ghyenne approved these changes

@darsene darsene darsene approved these changes

@benjaminlepine benjaminlepine Awaiting requested review from benjaminlepine

@karim-ovh karim-ovh Awaiting requested review from karim-ovh

Assignees

No one assigned

Labels

quality check: ok universe-bare-metal-cloud

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pdepaepe @ghyenne @darsene @qpavy