Skip to content

Feat/key management service b3 #12795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vovh merged 15 commits into from
Oct 15, 2024
Merged

Feat/key management service b3 #12795

vovh merged 15 commits into from
Oct 15, 2024

Conversation

@vovh
Copy link
Contributor

@vovh vovh commented Aug 20, 2024 •
edited
Loading

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-14045
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

  • CMT-16948

@vovh vovh changed the base branch from master to develop August 20, 2024 09:05
@github-actions github-actions bot removed universe-bare-metal-cloud dependencies Pull requests that update a dependency file sign-up common labels Aug 20, 2024
@vovh vovh force-pushed the feat/key-management-service-B3 branch from 9178382 to c60768b Compare August 23, 2024 12:07
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Aug 29, 2024
@vovh vovh changed the base branch from develop to master August 30, 2024 09:51
@vovh vovh force-pushed the feat/key-management-service-B3 branch from c60768b to 8c2c824 Compare August 30, 2024 09:57
@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging and removed has conflicts Has conflicts to resolve before merging labels Aug 30, 2024
@rjamet-ovh rjamet-ovh force-pushed the feat/key-management-service-B3 branch from 91c4f48 to 09ca617 Compare September 12, 2024 13:55
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Sep 12, 2024
@rjamet-ovh rjamet-ovh force-pushed the feat/key-management-service-B3 branch 2 times, most recently from 5397b2c to faa1db3 Compare September 23, 2024 12:48
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Sep 24, 2024
@rjamet-ovh rjamet-ovh force-pushed the feat/key-management-service-B3 branch from 796b2e3 to 9158906 Compare October 10, 2024 08:43
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 10, 2024
vovh and others added 5 commits October 15, 2024 09:16
@vovh
feat(key-management-service): credential template
aa41709 
ref: MANAGER-14184

Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
feat(kms): add credentials list
fa1a550 
ref: MANAGER-13769

Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
feat(kms): remove sorting on credential list
0be63d9 
ref: MANAGER-13769

Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
@vovh @darsene
feat(key-management-service): credentials creation step 1 (#12914)
970dec1 
ref: MANAGER-13570

Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
Co-authored-by: David Arsène <david.arsene.ext@ovhcloud.com>
feat(kms): add credential dashboard
3bfae85 
ref: MANAGER-13768

Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
Romain Jamet and others added 5 commits October 15, 2024 09:16
feat(kms): add delete credential
5a855b4 
ref: MANAGER-14199

Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
@vovh
feat(kms): improve calendar and textera at credential creation (#13221)
cd1def7 
ref: MANAGER-15212

Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
@darsene
fix(key-management-service): add info for cert custom validity date
9114516 
ref: MANAGER-15219

Signed-off-by: David Arsène <david.arsene.ext@ovhcloud.com>
@vovh
fix(kms): fix unexpected error on datepicker in credential creation (#…
ea47efc 
…13373)

ref: MANAGER-15441

Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
@vovh
fix(kms): keep data after unmount component on credential creation (#…
a06e2b8 
…13518)

ref: MANAGER-15319

Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
@rjamet-ovh rjamet-ovh force-pushed the feat/key-management-service-B3 branch from 3720f80 to a06e2b8 Compare October 15, 2024 08:03
@vovh @ovh-cds
fix(i18n): add missing translations [CDS 3400]
10d44c5 
Signed-off-by: CDS Translator Agent <opensource@ovh.net>
@vovh vovh changed the base branch from master to release/key-management-service-B3 October 15, 2024 12:09
fix(kms): fix sonarcloud issue
517a6cb 
ref: MANAGER-14045

Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
@rjamet-ovh rjamet-ovh force-pushed the feat/key-management-service-B3 branch from 0234906 to 517a6cb Compare October 15, 2024 12:09
@vovh vovh self-assigned this Oct 15, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 15, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@vovh vovh marked this pull request as ready for review October 15, 2024 12:12
@vovh vovh requested a review from a team October 15, 2024 12:12
@vovh vovh requested a review from a team as a code owner October 15, 2024 12:12
@vovh vovh requested review from a team, ghyenne, oalkabouss, seven-amid, sidlynx and tibs245 and removed request for a team October 15, 2024 12:12
@vovh vovh merged commit bb1b239 into release/key-management-service-B3 Oct 15, 2024
@vovh vovh deleted the feat/key-management-service-B3 branch October 15, 2024 12:31
@vovh vovh mentioned this pull request Oct 15, 2024
Merged
1 task
vovh added a commit that referenced this pull request Oct 16, 2024
@vovh @darsene @ovh-cds
feat(kms): key management service batch 3 implementation (#12795)
25735c9 
ref: MANAGER-14045

Signed-off-by: Vincent BONMARCHAND <vincent.bonmarchand.ext@corp.ovh.com>
Co-authored-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
Co-authored-by: David Arsène <david.arsene.ext@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tibs245 tibs245 tibs245 approved these changes

@rjamet-ovh rjamet-ovh rjamet-ovh approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

@oalkabouss oalkabouss Awaiting requested review from oalkabouss

@ghyenne ghyenne Awaiting requested review from ghyenne

Assignees

@vovh vovh

Labels

enabler feature New feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vovh @tibs245 @rjamet-ovh @darsene