Skip to content

feat(iam): create policy action search no result improvement #9869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dectotam merged 4 commits into from
Jan 16, 2024
Merged

feat(iam): create policy action search no result improvement #9869

dectotam merged 4 commits into from
Jan 16, 2024

Conversation

@BrunoMarquesOVH
Copy link
Contributor

@BrunoMarquesOVH BrunoMarquesOVH commented Aug 21, 2023 •
edited
Loading

ref: MANAGER-11395

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-11395
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • ~~[ ] Breaking change is mentioned in relevant commits

Description

While creating a new policy in IAM manager, while searching for actions, we now add some feedback to user when there is no result.

Related

  • CMT-6985

qpavy
qpavy previously approved these changes Aug 22, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

qpavy
qpavy previously approved these changes Aug 25, 2023
View reviewed changes
y4nnL
y4nnL suggested changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@y4nnL y4nnL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actions search is disabled right now
It will be enabled by another PR, which means that this code will have to be updated

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

This Pull Request is stale due to inactivity since 30 days. If no activity happens for 15 more days from now, it will be closed.

@github-actions github-actions bot added the stale No activity since a long time label Sep 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

This Pull Request is now closed due to inactivity.

@github-actions github-actions bot closed this Oct 13, 2023
@BrunoMarquesOVH BrunoMarquesOVH removed the stale No activity since a long time label Dec 13, 2023
@jmalnuit jmalnuit requested a review from y4nnL December 15, 2023 09:17
anooparveti
anooparveti previously approved these changes Dec 15, 2023
View reviewed changes
@BrunoMarquesOVH
feat(iam): create policy action search with no result improvement
365d369 
ref: MANAGER-11395

Signed-off-by: Bruno MARQUES <bruno.marques.ext@corp.ovh.com>
@BrunoMarquesOVH BrunoMarquesOVH dismissed stale reviews from anooparveti and qpavy via 6c2ccc4 December 22, 2023 13:08
qpavy
qpavy previously approved these changes Dec 22, 2023
View reviewed changes
JacquesLarique
JacquesLarique previously approved these changes Dec 22, 2023
View reviewed changes
qpavy
qpavy previously approved these changes Dec 22, 2023
View reviewed changes
anooparveti
anooparveti previously approved these changes Dec 26, 2023
View reviewed changes
y4nnL
y4nnL previously approved these changes Jan 12, 2024
View reviewed changes
@BrunoMarquesOVH @ovh-cds
fix(i18n): add missing translations [CDS 2724]
59e3ca0 
Signed-off-by: CDS Translator Agent <opensource@ovh.net>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dectotam dectotam changed the base branch from master to release/components-w03 January 16, 2024 10:35
@dectotam dectotam changed the base branch from release/components-w03 to master January 16, 2024 11:07
@dectotam dectotam changed the base branch from master to release/components-w03 January 16, 2024 11:14
@dectotam dectotam merged commit 364c1c1 into release/components-w03 Jan 16, 2024
@dectotam dectotam deleted the feat/MANAGER-11395 branch January 16, 2024 12:06
@dectotam dectotam mentioned this pull request Jan 16, 2024
Merged
13 tasks
dectotam pushed a commit that referenced this pull request Jan 16, 2024
@BrunoMarquesOVH @ovh-cds
feat(iam): create policy action search no result improvement (#9869)
91bea17 
ref: MANAGER-11395

Signed-off-by: Bruno MARQUES <bruno.marques.ext@corp.ovh.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
qpavy pushed a commit that referenced this pull request Jan 19, 2024
@BrunoMarquesOVH @ovh-cds @qpavy
feat(iam): create policy action search no result improvement (#9869)
e03c0c0 
ref: MANAGER-11395

Signed-off-by: Bruno MARQUES <bruno.marques.ext@corp.ovh.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
qpavy pushed a commit that referenced this pull request Jan 19, 2024
@BrunoMarquesOVH @ovh-cds @qpavy
feat(iam): create policy action search no result improvement (#9869)
959bbd3 
ref: MANAGER-11395

Signed-off-by: Bruno MARQUES <bruno.marques.ext@corp.ovh.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
qpavy pushed a commit that referenced this pull request Jan 22, 2024
@BrunoMarquesOVH @ovh-cds @qpavy
feat(iam): create policy action search no result improvement (#9869)
0758e3c 
ref: MANAGER-11395

Signed-off-by: Bruno MARQUES <bruno.marques.ext@corp.ovh.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qpavy qpavy qpavy approved these changes

@anooparveti anooparveti anooparveti left review comments

@ghyenne ghyenne Awaiting requested review from ghyenne

+3 more reviewers

@dectotam dectotam dectotam approved these changes

@y4nnL y4nnL y4nnL left review comments

@JacquesLarique JacquesLarique JacquesLarique left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature New feature quality check: ok

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@BrunoMarquesOVH @y4nnL @dectotam @qpavy @anooparveti @JacquesLarique