[PWCI] "packet capture bugfixes and secondary process" #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds SM2 elliptic curve based asymmetric encryption and decryption to the Intel QuickAssist Technology PMD. Signed-off-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com> Signed-off-by: Kai Ji <kai.ji@intel.com>
This commit adds tests cases to be used when C1 or kP elliptic curve points need to be computed. Signed-off-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com> Signed-off-by: Kai Ji <kai.ji@intel.com>
Add missing elliptic curves capabilities. Small fixes on ECDH implementation. Signed-off-by: Radu Nicolau <radu.nicolau@intel.com> Acked-by: Kai Ji <kai.ji@intel.com>
Add ECDH, ECPM and ECDSA tests for QAT Signed-off-by: Radu Nicolau <radu.nicolau@intel.com> Acked-by: Kai Ji <kai.ji@intel.com>
Read EC parameters from the xform, not from the asym_op, where they may not be set. Fixes: 305e1f8 ("crypto/qat: add ECDH key exchange algorithm") Cc: stable@dpdk.org Signed-off-by: Radu Nicolau <radu.nicolau@intel.com> Acked-by: Kai Ji <kai.ji@intel.com>
Fix performance regression resulting from using non cache-aligned source buffers when using cryptodev API. Fixes: fb3b9f4 ("crypto/qat: rework burst data path") Cc: stable@dpdk.org Signed-off-by: Radu Nicolau <radu.nicolau@intel.com> Acked-by: Kai Ji <kai.ji@intel.com>
Receive cpt context ilen as devarg parameter and configure lf. Signed-off-by: Nithinsen Kaithakadan <nkaithakadan@marvell.com>
Remove return statement. Fix compilation error in debug mode. Fixes: 8fc370e ("crypto/cnxk: add CN20K security skeleton") Cc: stable@dpdk.org Signed-off-by: Nithinsen Kaithakadan <nkaithakadan@marvell.com>
This patch introduces a new API to get FPM table host address. Signed-off-by: Sucharitha Sarananaga <ssarananaga@marvell.com>
This patch introduces a new API to get AE EC group table address and added static_assert checks to ensure that each enum value in roc_ae_ec_id matches its expected constant. This helps catch accidental changes or reordering of enum values at compile time. Signed-off-by: Sucharitha Sarananaga <ssarananaga@marvell.com>
Change the alignment of cptr to 256 bytes from 128 bytes in cn20k. Signed-off-by: Nithinsen Kaithakadan <nkaithakadan@marvell.com>
This patch avoid copying the decrypted message into the signature buffer, which is actually an input to the verify operation. This prevents overwriting the input buffer unnecessarily. Fixes: 6661bed ("crypto/cnxk: add asymmetric datapath") Cc: stable@dpdk.org Signed-off-by: Sucharitha Sarananaga <ssarananaga@marvell.com>
Aligning PDCP API with latest firmware. Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
Adding support for custom metadata in cn20k PMD. Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
Adding ROC layer optimizations. Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
Fix mbuf sanity check failure by zeroing data_len of each segment from the target len onward and adjusting pkt_len in the head mbuf. Hence by avoiding call to free mbuf from intermediate node. Fixes: 9a126e7 ("crypto/cnxk: support TLS padding verification") Fixes: c05eb27 ("crypto/cnxk: add CN20K TLS post-process") Cc: stable@dpdk.org Signed-off-by: Nithinsen Kaithakadan <nkaithakadan@marvell.com>
This patch resolves the following mbuf sanity check errors.
- updating nb_segs and pkt_len in the head mbuf after
freeing intermediate nodes in the chain.
- fix incorrect usage of rte_pktmbuf_append by ensuring
the head mbuf is passed instead of an intermediate
node, allowing proper tail detection and metadata
update.
Fixes: dc3f6c5 ("test/crypto: fix wireless auth digest segment")
Fixes: 4322009 ("test/crypto: add PDCP cases for scatter gather")
Fixes: dcdd016 ("test/crypto: add GMAC SGL")
Fixes: f3dbf94 ("app/test: check SGL on QAT")
Cc: stable@dpdk.org
Signed-off-by: Nithinsen Kaithakadan <nkaithakadan@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
Added a check to verify that user configured modlen supported or not. Signed-off-by: Sucharitha Sarananaga <ssarananaga@marvell.com> Acked-by: Akhil Goyal <gakhil@marvell.com>
This patch addresses an issue where execution operations were failing despite the optype parameter being correctly configured. The failure occurring because it is executing rsa optype params check instead of configured optype and removed copying of sign data into temporary buffer. Fixes: e131b8e ("app/crypto-perf: add RSA test vectors") Cc: stable@dpdk.org Signed-off-by: Sucharitha Sarananaga <ssarananaga@marvell.com> Acked-by: Akhil Goyal <gakhil@marvell.com>
Add support for ECDSA SECP384R1 curve SIGN and VERIFY operations Signed-off-by: Rupesh Chiluka <rchiluka@marvell.com> Acked-by: Akhil Goyal <gakhil@marvell.com>
In cases like RSA which has low performance numbers compared to AES, the Mops and gbps may not give accurate results. Hence updated the number of decimal places to have meaningful results. The results are not updated to show Kops or mbps as the results may be used in CI scripts which considers them as Mops/gbps and hence all scripts will need to be updated. Signed-off-by: Akhil Goyal <gakhil@marvell.com>
When test vector plaintext exceeds buffer size, only the first max_buffer_size bytes are processed, causing incorrect digest verification (computed vs expected mismatch). This patch fixes this issue by checking that the plaintext size is larger than the buffer size and returns an error with a log. Fixes: f8be178 ("app/crypto-perf: introduce performance test application") Cc: stable@dpdk.org Signed-off-by: Shani Peretz <shperetz@nvidia.com> Acked-by: Kai Ji <kai.ji@intel.com> Acked-by: Akhil Goyal <gakhil@marvell.com>
The test dummy vector data is incorrect for AEAD decryption, so we should only run when passed a valid test vector file. Signed-off-by: Emma Finn <emma.finn@intel.com> Acked-by: Kai Ji <kai.ji@intel.com> Acked-by: Akhil Goyal <gakhil@marvell.com>
Add support for PQC ML-KEM and ML-DSA algorithms. Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> Acked-by: Akhil Goyal <gakhil@marvell.com>
Add ML-KEM and ML-DSA support. Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> Acked-by: Akhil Goyal <gakhil@marvell.com>
Add ML-KEM and ML-DSA test cases and test vectors. Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> Acked-by: Akhil Goyal <gakhil@marvell.com>
Adds definitions for PDCP checksums and APIs to pass in dictionaries for deflate and inflate operations. Signed-off-by: Sameer Vaze <svaze@qti.qualcomm.com> Acked-by: Ashish Gupta <ashishg@marvell.com> Acked-by: Akhil Goyal <gakhil@marvell.com>
Support to calculate PDCP checksums. Includes changes to pass in dictionaries for deflate and inflate operations. Adds support for sync flush as well. Signed-off-by: Sameer Vaze <svaze@qti.qualcomm.com> Acked-by: Ashish Gupta <ashishg@marvell.com>
Adds support to read and apply dictionaries for inflate and deflate. Signed-off-by: Sameer Vaze <svaze@qti.qualcomm.com> Acked-by: Ashish Gupta <ashishg@marvell.com>
Improve CPU code path with support for OOP and various small fixes. Signed-off-by: Radu Nicolau <radu.nicolau@intel.com> Acked-by: Kai Ji <kai.ji@intel.com>
In the case when PMD cannot support the full process of the SM2, but elliptic curve computation only, additional fields are needed to handle such a case. Points C1, kP therefore were added to the SM2 crypto operation struct. Signed-off-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com> Signed-off-by: Kai Ji <kai.ji@intel.com> Acked-by: Akhil Goyal <gakhil@marvell.com>
Add a script to easily add entries to, check and sort the mailmap file. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> Reviewed-by: Robin Jarry <rjarry@redhat.com> Acked-by: Marat Khalili <marat.khalili@huawei.com>
Sort mailmap in alphabetical order, such that shorter names come before longer names i.e. "Dan Programmer" comes before "Daniel Coder", not after. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Refactored rte_pktmbuf_prefree_seg() for both performance and readability. With the optimized RTE_MBUF_DIRECT() macro, the common likely code path now fits within one instruction cache line on x86-64 when built with GCC. Signed-off-by: Morten Brørup <mb@smartsharesystems.com> Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com> Acked-by: Chengwen Feng <fengchengwen@huawei.com> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
In the documentation, make clear rte_align(32|64)prevpow2(<n>) -> <n>, provided <n> is a power of 2. The original documentation stated the "previous" power of 2 would be returned, potentially leaving the user to erroneously conclude that, for example, rte_align32prevpow2(32) -> 16. The rte_align(32|64)pow2(<n>) documentation, suffering from a similar issue, is reworded in the same manner. Fixes: 08f6831 ("eal: add functions for previous power of 2 alignment") Cc: stable@dpdk.org Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Morten Brørup <mb@smartsharesystems.com>
wrr tokens getting truncated to uint8_t in wrr_store function() due to type mismatch. This patch changes the data type to uint16_t. Fixes: e16b06d ("sched: remove WRR from strict priority TC queues") Cc: stable@dpdk.org Signed-off-by: Megha Ajmera <megha.ajmera@intel.com> Acked-by: Jasvinder Singh <jasvinder.singh@intel.com> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
When compiled with Link Time Optimization, the existing code
generated an error, because the compiler was unable to intuit
that there was space in the flexible array.
In function ‘test_argparse_copy’,
inlined from ‘test_argparse_init_obj’
at ../app/test/test_argparse.c:108:2,
inlined from ‘test_argparse_opt_callback_parse_int_of_no_val’
at ../app/test/test_argparse.c:490:8:
../app/test/test_argparse.c:96:17: warning:
‘memcpy’ writing 56 bytes into a region of size 0 overflows the destination
memcpy(&dst->args[i], &src->args[i], sizeof(src->args[i]));
Initializing a structure with flexible array is special case
and compiler expands the structure to fit.
But inside the copy function it no longer knew that.
The workaround is to put the copy inside the same function
and use structure assignment. Also macro should be upper case.
Fixes: 6c5c657 ("argparse: verify argument config")
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Use of comma as statement separator is discouraged and reported as warning by clang with -Wcomma Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com> Acked-by: Chengwen Feng <fengchengwen@huawei.com> Acked-by: Morten Brørup <mb@smartsharesystems.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Use of comma as statement separator is discouraged and reported as warning by clang with -Wcomma Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com> Acked-by: Chengwen Feng <fengchengwen@huawei.com> Acked-by: Morten Brørup <mb@smartsharesystems.com>
Use of comma as statement separator is discouraged and reported as warning by clang with -Wcomma Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com> Acked-by: Chengwen Feng <fengchengwen@huawei.com> Acked-by: Morten Brørup <mb@smartsharesystems.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Use while with brackets in favor of comma operator. In flow print replace with temporary variable. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Chengwen Feng <fengchengwen@huawei.com> Acked-by: Morten Brørup <mb@smartsharesystems.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Use of comma as statement separator is discouraged and reported as warning by clang with -Wcomma Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Use semicolon to break lines. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Should use semicolon here. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Clang (3.9 or later) has a -Wcomma that emits warnings for questionable uses of the comma operator. Don't enable it for drivers since many drivers still use comma operator unnecessarily. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com> Acked-by: Chengwen Feng <fengchengwen@huawei.com> Acked-by: Morten Brørup <mb@smartsharesystems.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Configuration for hex code '0xd49' enables two NUMA nodes. Then, the corresponding 'soc_n2' should allow 'numa'. Fixes: ea85ed1 ("config/arm: increase nodes and cores for Neoverse N2") Cc: stable@dpdk.org Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com> Acked-by: Doug Foster <doug.foster@arm.com>
Refactor README to contain only a high level description of relevant DTS concepts and a simple getting started guide. Signed-off-by: Dean Marx <dmarx@iol.unh.edu> Reviewed-by: Patrick Robb <probb@iol.unh.edu> Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>
Right after setting up VFIO device, we attempt to fill region information. This operation can fail, and if it does, we do not release the device fd. Fix the control flow to free the device fd if getting region info failed. Fixes: 4b74154 ("bus/pci: avoid depending on private kernel value") Cc: stable@dpdk.org Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Update maintainers for LoongArch architecture. Signed-off-by: Min Zhou <zhoumin@loongson.cn> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
If primary process exits, then it is not possible (or needed) to cleanup resources. Instead just exit after closing the capture file. Bugzilla ID: 1760 Fixes: cbb4414 ("app/dumpcap: add new packet capture application") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Signed-off-by: 0-day Robot <robot@bytheb.org>
If primary process exits, then it is not possible (or needed) to cleanup resources. Instead just exit after closing the capture file. Bugzilla ID: 1760 Fixes: a99a311 ("app/pdump: exit with primary process") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Signed-off-by: 0-day Robot <robot@bytheb.org>
The pdump callback can race with other cpu's in the datapath. Handle this by using reference counts and LSB in manner similar to seqcount and bpf code. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Signed-off-by: 0-day Robot <robot@bytheb.org>
The primary process will start to notify all secondary processes about pdump changes. The dumpcap secondary process can just call rte_pdump_init() and it take care of that. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Signed-off-by: 0-day Robot <robot@bytheb.org>
The primary process will start to notify all secondary processes about pdump changes. The pdump secondary process can just call rte_pdump_init() and it take care of that. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Signed-off-by: 0-day Robot <robot@bytheb.org>
When packet capture is enabled, need to also notify secondary processes to force them to do the callbacks. Requires that all secondary processes also call rte_pdump_init() or there will be warning about not responding secondary. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Signed-off-by: 0-day Robot <robot@bytheb.org>
Replace variable length array with refactored loop so that packets are processed in bursts of up to 32. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Signed-off-by: 0-day Robot <robot@bytheb.org>
The documentation was missing some of the API, and had some awkward wording. With the help of ChatGPT, update it and make it more concise. Add a release note Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Signed-off-by: 0-day Robot <robot@bytheb.org>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
The pull request #241 has too many files changed.
The GitHub API will only let us fetch up to 300 changed files, and this pull request has 720.
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 93 files out of 299 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
34 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-submission for "http://patchwork.dpdk.org/project/dpdk/list/?series=36463"