Test: ARGS NAMES #23
Merged
Test: ARGS NAMES #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebitosh <soloplayerdiablo@gmail.com>
Sebitosh
force-pushed
the
args_names_test
branch
from
2183fe2 to
15c46a4
Compare
Contributor
Author
|
rebased & re-generated rules/tests |
airween
approved these changes
Apr 21, 2025
Member
|
Thanks, @Sebitosh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ARGS NAMES test.
Tested in two parts: checking args names on GET request in phase 1-4, and args names on POST requests in phase 2-4.
Went for this test because ARGS NAMES is used 171 times ins CRS v4.8.0 according to https://crsdoc.digitalwave.hu
Note
I used the same naming convention as proposed in #22 (and we should confirm this is good or not).
I will need to rebase and regenerate rules and tests when #22 is merged (because of changing rule ids in the XML tests, that have a higher numbering on them).