-
Notifications
You must be signed in to change notification settings - Fork 2.1k
revert logic to expose free_space, but keep availableStorage config #40669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is mainly for streams that don't wrap another one, or use a stream not provided by the native fopen function such as smbclient_open
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
Revert .htaccess change
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Upgrading phpseclib/phpseclib (3.0.18 => 3.0.19)
Ocm via sciencemesh for 10.12
PR #40670 has this code with the conflict resolved. |
"Piotr Mrowczynski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA" It looks like the name used in the commit is missing the "accent" characters in "Piotr Mrówczyński" |
22f6b32
to
1dadab4
Compare
💥 Acceptance tests pipeline webUIFiles-chrome-mariadb10.2-php7.4 failed. The build has been cancelled. |
Kudos, SonarCloud Quality Gate passed! |
Note: this PR now has 20 commits - the switch back to |
This code has been merged to IMO this PR to master can be closed. |
The issue here is that originally when doing #40389 I somehow mixed the storage_id for S3 bucket with the user urns storage_id's . So when matching with filecache I though it represents that one.
However I was wrong, and used the wrong storage .. also the correct filecache entry for the entire bucket is always showing 0 size.
In this PR, I just expose the config entry for availableStorage, so that apps could use it. Please note that this PR reverts logic to expose this on storage level, so all "quota" calculations wont work. If we want to make it work on storage level, something like background job that calculates this size would need to be done. However, metrics app does not require that complexity and it can simply just use that parameters as in https://github.com/owncloud/metrics/pull/159