Skip to content

Conversation

mrow4a
Copy link
Contributor

@mrow4a mrow4a commented Mar 6, 2023

The issue here is that originally when doing #40389 I somehow mixed the storage_id for S3 bucket with the user urns storage_id's . So when matching with filecache I though it represents that one.

However I was wrong, and used the wrong storage .. also the correct filecache entry for the entire bucket is always showing 0 size.

In this PR, I just expose the config entry for availableStorage, so that apps could use it. Please note that this PR reverts logic to expose this on storage level, so all "quota" calculations wont work. If we want to make it work on storage level, something like background job that calculates this size would need to be done. However, metrics app does not require that complexity and it can simply just use that parameters as in https://github.com/owncloud/metrics/pull/159

@mrow4a mrow4a requested a review from DeepDiver1975 March 6, 2023 08:30
@mrow4a mrow4a self-assigned this Mar 6, 2023
@update-docs
Copy link

update-docs bot commented Mar 6, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2023

CLA assistant check
All committers have signed the CLA.

@mrow4a mrow4a marked this pull request as ready for review March 6, 2023 08:41
@mrow4a mrow4a requested a review from jnweiger March 6, 2023 08:44
phil-davis and others added 2 commits March 6, 2023 14:31
@jnweiger jnweiger changed the base branch from master to release-10.12.0 March 6, 2023 10:51
@jnweiger jnweiger requested a review from pako81 March 6, 2023 10:55
@phil-davis
Copy link
Contributor

PR #40670 has this code with the conflict resolved.

@phil-davis
Copy link
Contributor

"Piotr Mrowczynski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA"

It looks like the name used in the commit is missing the "accent" characters in "Piotr Mrówczyński"

@mrow4a mrow4a force-pushed the fix-core-40665 branch 2 times, most recently from 22f6b32 to 1dadab4 Compare March 6, 2023 12:33
@owncloud owncloud deleted a comment from ownclouders Mar 6, 2023
@ownclouders
Copy link
Contributor

ownclouders commented Mar 6, 2023

💥 Acceptance tests pipeline webUIFiles-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/38051/124

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jnweiger jnweiger changed the base branch from release-10.12.0 to master March 6, 2023 15:26
@phil-davis
Copy link
Contributor

phil-davis commented Mar 7, 2023

Note: this PR now has 20 commits - the switch back to master recorded by GitHub 17 hours ago did not do what we want.
New PR is coming - see #40674

@phil-davis
Copy link
Contributor

This code has been merged to release-10.12.0 in PR #40674

IMO this PR to master can be closed.

@pako81 pako81 closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] public links do not work with files_primary_s3
8 participants