This repository was archived by the owner on Jul 24, 2018. It is now read-only.
Use context instead of static access #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@PVince81 In general I'd be happy if it would be possible just use |
Contributor
Author
|
You mean have some kind of FileInfo object on which you can retrieve properties ? |
Contributor
Author
|
Actually the problem is that there shouldn't be a stateful "current file". The file is only current within the function call. Having static attributes on the FileActions like before (which I want to get rid of in the future) has the risk of containing outdated values. Anyway, do you need me to make any changes to this PR ? |
Contributor
|
@PVince81 No, it looks good |
VicDeo
added a commit
that referenced
this pull request
Jul 9, 2014
Use context instead of static access
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@VicDeo this fix will be required soon as I'm fixing FileActions stuff.
We should avoid static access to attributes of fileActions in the future.