Skip to content
This repository was archived by the owner on Jul 24, 2018. It is now read-only.

Conversation

@VicDeo
Copy link
Contributor

@VicDeo VicDeo commented Jul 9, 2014

Do a quick doc->odt conversion test and log raw openoffice output in case there is no output file

Ref #291

@brantje
Copy link

brantje commented Jul 9, 2014

👍 works here.
Maybe a message that the test was successful?

@VicDeo
Copy link
Contributor Author

VicDeo commented Jul 9, 2014

@brantje ok, done :)
thanks for testing

ajax/admin.php Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add escapeshellarg to prevent false positives by automated vulnerability scanners. Thanks.

@VicDeo
Copy link
Contributor Author

VicDeo commented Jul 9, 2014

@LukasReschke thanks for reviewing it. Updated.

@VicDeo
Copy link
Contributor Author

VicDeo commented Jul 9, 2014

@karlitschek may I backport it to stable7?
It is very useful for detecting libreoffice failure reasons

@karlitschek
Copy link

of course. please do :-)

VicDeo added a commit that referenced this pull request Jul 9, 2014
Test local conversion when saving the settings
@VicDeo VicDeo merged commit 39a493d into master Jul 9, 2014
@VicDeo VicDeo deleted the local-conversion-test branch July 9, 2014 20:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants