Set home directory for libreoffice conversion #310
Conversation
|
@owncloud-bot ok to test |
|
Just tested and it seems to work. Thank you! 👍 |
There was a problem hiding this comment.
@josh4trunks I guess \OCP\Files::tmpFolder is better
There was a problem hiding this comment.
@VicDeo I tried using that af first but it would generate a random folder each time. We want a consistent location so Documents doesn't need to create 1MB+ of files everytime it generates a preview. How about DATADIRECTORY/documents instead? I know the notes add uses DATADIRECTORY/notes for all its stuff.
There was a problem hiding this comment.
oops, I should read your explanation before looking into the code.
This openoffice dir seems to have nothing private inside so get_temp_dir is good too.
escapeshellarg is needed here though
There was a problem hiding this comment.
you mean save get_temp_dir to a variable then use escapeshellarg?
I can do this tonight when I get back from work;otherwise feel free to make the changes if you'd like. We also need this line added to the conversion test on the admin page.
|
@josh4trunks like that #311 |
3 participants
Fixes #291 (comment)
I use owncloud's get_temp_dir() because \OCP\Files::tmpFolder(); would change every call. This would be alot of wasted IO + CPU because the 1MB+ user directory would need to be created repeatedly.