Skip to content
This repository was archived by the owner on Oct 31, 2018. It is now read-only.

Conversation

@karakayasemi
Copy link
Contributor

Add oracle support on travis. #5

@DeepDiver1975
Copy link
Contributor

This needs some more to be added - e.g. owncloud/oauth2#42

@DeepDiver1975
Copy link
Contributor

@karakayasemi will you continue with this? THX

@karakayasemi
Copy link
Contributor Author

Yes, I will when I make time for it. Thanks.

@karakayasemi karakayasemi force-pushed the addOracleTest branch 2 times, most recently from 7736286 to b827bb0 Compare December 20, 2017 07:08
@karakayasemi karakayasemi self-assigned this Dec 20, 2017
@codecov-io
Copy link

codecov-io commented Dec 20, 2017

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #15   +/-   ##
=========================================
  Coverage     70.56%   70.56%           
  Complexity       70       70           
=========================================
  Files            12       12           
  Lines           282      282           
=========================================
  Hits            199      199           
  Misses           83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bc997f...2a9c9cf. Read the comment docs.

@karakayasemi karakayasemi force-pushed the addOracleTest branch 6 times, most recently from 7cba5a4 to 0c0eff2 Compare December 23, 2017 15:29
@karakayasemi
Copy link
Contributor Author

Finally, all tests succeeded. There was a problem in before_install_oracle_module.sh. IMHO, the other repos which have tests for Oracle should apply the change to script for php7 and 7.1 with oracle env.
https://github.com/owncloud/security/blob/2a9c9cf08c0c4359362d57da94e05b23c19fa2cf/tests/.travis/before_install_oracle_module.sh#L12

@DeepDiver1975 DeepDiver1975 merged commit 6e8eaf2 into master Jan 8, 2018
@DeepDiver1975 DeepDiver1975 deleted the addOracleTest branch January 8, 2018 08:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants