This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Conversation
PVince81
reviewed
Jun 4, 2018
Contributor
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
Code looks good.
No chance at unit tests ?
Member
Author
|
@PVince81 possible but proper tests need rewriting TemplateEditor class by ~ 80% and potentially requires changing more than 2 files As for now the change is wrapped with |
Contributor
|
@VicDeo please raise a tech debt ticket "make template editor testable" and add a quick estimate. Then we can merge this here. |
Member
Author
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
can not find templatefor the plain text activity templatedepends on owncloud/activity#620