Refactor TemplateEditor, add footer templates and templates from notifications app

[VicDeo]

• [improvement] Implement best practices in code #70 Implement best practices in code
• Add notification email templates to editable list #73 Add notification email templates to editable list
• Add footer template to editable list #71 Add footer template to editable list
• setup unit testing and add first unit test :)

Test cases:

• 10.0.8 should not offer edit mail footer templates
• 10.0.9+ should offer edit mail footer templates (HTML and plain)
• in case notifications app is enabled, it's mail templates should appear in the list too

[PVince81]

[VicDeo]

@PVince81 tests added

[PVince81]

10.0.9 or is 8 enough ?

[VicDeo]

There is nothing 10.0.9-specific, I added a check for footers so 10.0.8 users will not see common mail footers in the list

[PVince81]

weird, I thought it would be enough to just put .. here since that would point at the tests folder, based on the path where phpunit.xml is located ?

[VicDeo]

IDK. Being a lazy ass I just copied this config from another app :)

[PVince81]

Damn... so other apps are doing that too.

Can you adjust so that to avoid next copy-paste victim ? :-D

[VicDeo]

@PVince81 path in tests/unit/phpunit.xml has been changed

[PVince81]

👍

[patrickjahns]

@PVince81 - tests have been added - but none are executed in CI :'(

Are still with travis :'(

[PVince81]

let's do this then before the release #83