Skip to content
This repository was archived by the owner on Oct 9, 2025. It is now read-only.

Conversation

@dev-737
Copy link
Member

@dev-737 dev-737 commented May 17, 2024

This pull request refactors the handleComponents method in command classes to be static. This change improves code organization and ensures consistency across command implementations.

@dev-737 dev-737 changed the title "Refactor handleComponents method to static in command classes" refactor: handleComponents method to static in command classes and some deepsource hotfixes May 17, 2024
@deepsource-io
Copy link

deepsource-io bot commented May 17, 2024

Here's the code health analysis summary for commits 43c1862..f803b07. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 4 occurences introduced
🎯 45 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@graphite-app
Copy link

graphite-app bot commented May 17, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (05/17/24)

1 assignee was added to this PR based on 's automation.

dev-737 and others added 5 commits May 17, 2024 23:01
This commit fixes an issue in the Manage command where the BlockNSFW setting was not working correctly. The code now properly handles the setting and displays an error message if it cannot be changed yet. This resolves a bug reported by users.

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
This commit refactors the Connection class in the slash/Main directory. It introduces two new methods, executeStringSelects and executeChannelSelects, to handle string and channel select menu interactions respectively. This improves code organization and readability. The changes also include updating the method names in the code to match the new method names.

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
@dev-737 dev-737 merged commit 47b1b64 into main May 18, 2024
@dev-737 dev-737 deleted the some_random_refactor_woo branch May 18, 2024 03:50
@sentry
Copy link

sentry bot commented May 20, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ DiscordAPIError[10062]: Unknown interaction Function.executeStringSelects(connection.ts) View Issue
  • ‼️ DiscordAPIError[10062]: Unknown interaction Function.executeStringSelects(connection.ts) View Issue
  • ‼️ DiscordAPIError[10062]: Unknown interaction handleComponents(browse.ts) View Issue
  • ‼️ DiscordAPIError[10062]: Unknown interaction Function.executeStringSelects(connection.ts) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants