Skip to content

Conversation

@oxc-bot
Copy link
Contributor

@oxc-bot oxc-bot commented Jun 26, 2025

No description provided.

@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.74%. Comparing base (70a58c0) to head (cc2836c).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files          14       14           
  Lines        2943     2943           
=======================================
  Hits         2759     2759           
  Misses        184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oxc-bot oxc-bot force-pushed the release-plz-2025-06-26T05-08-38Z branch from 6ff14eb to aa61ade Compare June 26, 2025 05:09
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 26, 2025

CodSpeed Performance Report

Merging #574 will not alter performance

Comparing release-plz-2025-06-26T05-08-38Z (cc2836c) with main (78d8e12)

Summary

✅ 3 untouched benchmarks

@oxc-bot oxc-bot force-pushed the release-plz-2025-06-26T05-08-38Z branch 11 times, most recently from b23ec10 to 5df270e Compare June 26, 2025 08:09
@oxc-bot oxc-bot force-pushed the release-plz-2025-06-26T05-08-38Z branch from 5df270e to 447a166 Compare June 26, 2025 08:10
@Boshen Boshen changed the title chore: release v12.0.0 chore: release v11.3.0 Jun 26, 2025
@Boshen Boshen merged commit 78d8e12 into main Jun 26, 2025
17 checks passed
@Boshen Boshen deleted the release-plz-2025-06-26T05-08-38Z branch June 26, 2025 08:32
[package]
name = "oxc_resolver"
version = "11.2.1"
version = "11.3.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the PR description, there are breaking API changes in both oxc_resolver and oxc_resolver_napi. The semver check failures indicate that:

  1. ResolveOptions struct has new required fields
  2. A field was removed from ResolveOptions
  3. ResolveResult has a new required field

Following semantic versioning principles, these breaking changes require a major version bump to 12.0.0 rather than the minor version bump to 11.3.0 shown here. This ensures downstream consumers are properly notified of the incompatible API changes.

Suggested change
version = "11.3.0"
version = "12.0.0"

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants