Skip to content

Commit 5939f45

Browse files
authored
minor: xterm.js 6.0 (#3156)
Nice release, they haven't had one in two years. Lots of small fixes. Only visible difference is the scrollbar is now wider. Everything seems to work fine. https://github.com/xtermjs/xterm.js/releases/tag/6.0.0
1 parent a02b888 commit 5939f45

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

package-lock.json

Lines changed: 13 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@
4444
"@tanstack/react-query": "^5.90.7",
4545
"@tanstack/react-query-devtools": "^5.90.2",
4646
"@tanstack/react-table": "^8.20.5",
47-
"@xterm/addon-fit": "^0.10.0",
48-
"@xterm/xterm": "^5.5.0",
47+
"@xterm/addon-fit": "^0.11.0",
48+
"@xterm/xterm": "^6.0.0",
4949
"classnames": "^2.5.1",
5050
"date-fns": "^3.6.0",
5151
"filesize": "^10.1.6",

test/e2e/theme.e2e.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,9 @@ test('Serial console terminal updates colors on theme change', async ({ page })
104104
const xterm = page.getByRole('application')
105105
await expect(xterm).toContainText('oxide-instance login:', { timeout: 15_000 })
106106

107-
// xterm.js sets background-color inline on the .xterm-viewport element
108-
const viewport = page.locator('.xterm-viewport')
109-
const getBg = () => viewport.evaluate((el) => getComputedStyle(el).backgroundColor)
107+
// xterm.js 6+ sets background-color inline on the .xterm-scrollable-element
108+
const scrollable = page.locator('.xterm-scrollable-element')
109+
const getBg = () => scrollable.evaluate((el) => getComputedStyle(el).backgroundColor)
110110

111111
const darkBg = await getBg()
112112

0 commit comments

Comments
 (0)