Move libs/api-mocks to top-level mock-api dir (#1976)

* move /app/test to /test

* move libs/api-mocks to mock-api

Author: david-crespo

README.md

@@ -10,10 +10,13 @@ import { fireEvent, render, screen } from '@testing-library/react'
 import ResizeObserverPolyfill from 'resize-observer-polyfill'
 import { beforeAll, describe, expect, it, vi } from 'vitest'
 
-import { clickByRole } from 'app/test/unit'
-
 import { DateTimeRangePicker, type RangeKey } from './DateTimeRangePicker'
 
+export function clickByRole(role: string, name: string) {
+  const element = screen.getByRole(role, { name })
+  fireEvent.click(element)
+}
+
 const now = getNow(getLocalTimeZone())
 
 function renderLastDay() {

app/components/form/fields/DateTimeRangePicker.spec.tsx

@@ -11,10 +11,9 @@ import { describe, expect, it, vi } from 'vitest'
 
 import { project } from '@oxide/api-mocks'
 
-import { overrideOnce } from 'app/test/unit'
-
 import { useApiMutation, useApiQuery } from '..'
 import type { DiskCreate } from '../__generated__/Api'
+import { overrideOnce } from '../../../test/unit/server'
 
 // because useApiQuery and useApiMutation are almost entirely typed wrappers
 // around React Query's useQuery and useMutation, these tests are mostly about

app/test/unit/index.tsx

@@ -33,22 +33,19 @@ const grepFiles = (s: string) =>
     .filter((f) => !/safety\.spec\.ts/.test(f)) // this file doesn't count
 
 it('@oxide/api-mocks is only referenced in test files', () => {
-  const files = grepFiles('api-mocks')
-  expect(files).toMatchInlineSnapshot(`
+  expect(grepFiles('api-mocks')).toMatchInlineSnapshot(`
     [
-      "README.md",
       "app/msw-mock-api.ts",
-      "app/test/e2e/instance-create.e2e.ts",
-      "app/test/e2e/inventory.e2e.ts",
-      "app/test/e2e/profile.e2e.ts",
-      "app/test/e2e/project-access.e2e.ts",
-      "app/test/e2e/silo-access.e2e.ts",
-      "app/test/e2e/utils.ts",
-      "app/test/unit/server.ts",
-      "app/test/unit/setup.ts",
-      "docs/mock-api-differences.md",
-      "libs/api-mocks/msw/db.ts",
       "libs/api/__tests__/hooks.spec.tsx",
+      "mock-api/msw/db.ts",
+      "test/e2e/instance-create.e2e.ts",
+      "test/e2e/inventory.e2e.ts",
+      "test/e2e/profile.e2e.ts",
+      "test/e2e/project-access.e2e.ts",
+      "test/e2e/silo-access.e2e.ts",
+      "test/e2e/utils.ts",
+      "test/unit/server.ts",
+      "test/unit/setup.ts",
       "tools/start_mock_api.ts",
       "tsconfig.json",
     ]
@@ -66,8 +63,8 @@ const listFiles = (s: string) =>
   execSync(`git ls-files | grep "${s}"`).toString().trim().split('\n')
 
 // avoid accidentally making an e2e file in the wrong place
-it('e2e tests are only in app/test/e2e', () => {
+it('e2e tests are only in test/e2e', () => {
   for (const file of listFiles('\\.e2e\\.')) {
-    expect(file).toMatch(/^app\/test\/e2e/)
+    expect(file).toMatch(/^test\/e2e/)
   }
 })