Turn read-only disks back on (#3155)

Putting this up early to help the team with testing.

Author: david-crespo

app/forms/disk-create.tsx

@@ -5,13 +5,6 @@
  *
  * Copyright Oxide Computer Company
  */
-// Read-only disk creation is disabled pending a propolis fix. To re-enable:
-// 1. Uncomment CheckboxField import and JSX in this file
-// 2. Uncomment CheckboxField JSX in app/forms/instance-create.tsx
-// 3. Use `values.bootDiskReadOnly` instead of hardcoded `false` in instance-create.tsx getBootDisk
-// 4. Use `source.readOnly` instead of hardcoded `false` in the onSubmit handler below
-// 5. Unskip e2e tests in test/e2e/disks.e2e.ts and test/e2e/instance-create.e2e.ts
-// https://github.com/oxidecomputer/console/issues/3071
 import { useQuery } from '@tanstack/react-query'
 import { filesize } from 'filesize'
 import { useMemo } from 'react'
@@ -30,7 +23,7 @@ import {
   type Image,
 } from '@oxide/api'
 
-// import { CheckboxField } from '~/components/form/fields/CheckboxField' // re-enable with #3071
+import { CheckboxField } from '~/components/form/fields/CheckboxField'
 import { DescriptionField } from '~/components/form/fields/DescriptionField'
 import { DiskSizeField } from '~/components/form/fields/DiskSizeField'
 import { toImageComboboxItem } from '~/components/form/fields/ImageSelectField'
@@ -179,14 +172,14 @@ export function CreateDiskSideModalForm({
                   // image ID is validated by the form: it's required when the
                   // field is present (i.e., when image type is selected)
                   imageId: source.imageId!,
-                  readOnly: false,
+                  readOnly: source.readOnly,
                 }))
                 .with({ type: 'snapshot' }, (source) => ({
                   type: 'snapshot' as const,
                   // snapshot ID is validated by the form: it's required when
                   // the field is present (i.e., when snapshot type is selected)
                   snapshotId: source.snapshotId!,
-                  readOnly: false,
+                  readOnly: source.readOnly,
                 }))
                 .exhaustive(),
             }))
@@ -377,28 +370,22 @@ const DiskSourceField = ({
                 }
               }}
             />
-            {/* Read-only disk creation disabled pending propolis fix
-                https://github.com/oxidecomputer/console/issues/3071
             <div className="mt-2">
               <CheckboxField name="diskBackend.diskSource.readOnly" control={control}>
                 Make disk read-only
               </CheckboxField>
             </div>
-            */}
           </>
         )}
 
         {diskSource.type === 'snapshot' && (
           <>
             <SnapshotSelectField control={control} />
-            {/* Read-only disk creation disabled pending propolis fix
-                https://github.com/oxidecomputer/console/issues/3071
             <div className="mt-2">
               <CheckboxField name="diskBackend.diskSource.readOnly" control={control}>
                 Make disk read-only
               </CheckboxField>
             </div>
-            */}
           </>
         )}
       </div>

app/forms/instance-create.tsx

@@ -115,7 +115,7 @@ const getBootDiskAttachment = (
       diskSource: {
         type: 'image',
         imageId: source,
-        readOnly: false,
+        readOnly: values.bootDiskReadOnly,
       },
     },
   }
@@ -510,8 +510,6 @@ export default function CreateInstanceForm() {
           }
         }}
       />
-      {/* Read-only disk creation disabled pending propolis fix
-          https://github.com/oxidecomputer/console/issues/3071
       <div key="divider3" className="my-6! content-['a']" />
       <CheckboxField
         key="bootDiskReadOnly"
@@ -521,7 +519,6 @@ export default function CreateInstanceForm() {
       >
         Make disk read-only
       </CheckboxField>
-      */}
     </>
   )
 

test/e2e/disks.e2e.ts

@@ -238,9 +238,7 @@ test('Create local disk with size > 1023 GiB', async ({ page }) => {
   })
 })
 
-// Read-only disk creation disabled pending propolis fix
-// https://github.com/oxidecomputer/console/issues/3071
-test.skip('Create disk from snapshot with read-only', async ({ page }) => {
+test('Create disk from snapshot with read-only', async ({ page }) => {
   await page.goto('/projects/mock-project/disks-new')
   await page.getByRole('textbox', { name: 'Name' }).fill('a-new-disk')
   await page.getByRole('radio', { name: 'Snapshot' }).click()
@@ -261,9 +259,7 @@ test.skip('Create disk from snapshot with read-only', async ({ page }) => {
   await expect(modal.getByLabel('e6c58826-62fb-4205-820e-620407cd04e7')).toBeVisible()
 })
 
-// Read-only disk creation disabled pending propolis fix
-// https://github.com/oxidecomputer/console/issues/3071
-test.skip('Create disk from image with read-only', async ({ page }) => {
+test('Create disk from image with read-only', async ({ page }) => {
   await page.goto('/projects/mock-project/disks-new')
   await page.getByRole('textbox', { name: 'Name' }).fill('a-new-disk')
   await page.getByRole('radio', { name: 'Image' }).click()

test/e2e/instance-create.e2e.ts

@@ -1302,9 +1302,7 @@ test('floating IPs are filtered by NIC IP version', async ({ page }) => {
   await expect(page.getByText('to attach a floating IP')).toBeVisible()
 })
 
-// Read-only disk creation disabled pending propolis fix
-// https://github.com/oxidecomputer/console/issues/3071
-test.skip('can create instance with read-only boot disk', async ({ page }) => {
+test('can create instance with read-only boot disk', async ({ page }) => {
   await page.goto('/projects/mock-project/instances-new')
 
   const instanceName = 'readonly-boot-instance'