tools: make visual baseline take a git revision arg (#2934)

Author: david-crespo

test/visual/README.md

@@ -4,11 +4,11 @@
 
 ### 1. Generate Baseline Snapshots
 
-First, generate baseline snapshots from a commit before your changes:
+First, generate baseline snapshots from some other revision:
 
 ```bash
-# Generate baseline from latest origin/main (most common)
-npm run visual:baseline -- --main
+# From main (most common)
+npm run visual:baseline
 
 # Or from a specific commit hash
 npm run visual:baseline -- abc123
@@ -17,7 +17,13 @@ npm run visual:baseline -- abc123
 npm run visual:baseline -- HEAD~1
 ```
 
-This will check out that revision in a git work tree, run the visual snapshot tests, and copy the snapshots back into your current working directory.
+This will check out that revision in a git worktree in a temp dir, run the
+visual snapshot tests, and copy the snapshots back into your current working
+directory.
+
+Note that this command does not fetch anything from the remote repo; it uses
+whatever you have locally. If you want to make sure you have the latest `main`,
+you need to pull it first.
 
 ### 2. Compare Current Changes
 

tools/generate-visual-baseline.sh

@@ -10,10 +10,9 @@ set -euo pipefail
 PROJECT_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
 cd "$PROJECT_ROOT"
 
-echo "Fetching latest from origin..."
-git fetch origin main --quiet
+REV=${1:-main}
 
-COMMIT=$(git rev-parse origin/main)
+COMMIT=$(git rev-parse "$REV")
 WORKTREE_DIR=$(mktemp -d -t visual-baseline-XXXXXX)
 
 cleanup() {
@@ -22,7 +21,7 @@ cleanup() {
 }
 trap cleanup EXIT INT TERM
 
-echo "Creating worktree at origin/main ($COMMIT)..."
+echo "Creating worktree at $REV ($COMMIT)..."
 git worktree add --detach "$WORKTREE_DIR" "$COMMIT" --quiet
 
 echo "Copying test files..."
@@ -35,7 +34,7 @@ echo "Installing dependencies..."
 npm ci
 
 echo "Generating baseline snapshots..."
-npx playwright test --config=playwright.visual.config.ts --project=chrome --update-snapshots
+npx playwright test --config=playwright.visual.config.ts --update-snapshots
 
 echo "Copying snapshots back..."
 cp -r test/visual/regression.e2e.ts-snapshots "$PROJECT_ROOT/test/visual/"